Issue 10270017: changed Run behavior http://code.google.com/p/dart/issues/detail?id=2730,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10270017: changed Run behavior http://code.google.com/p/dart/issues/detail?id=2730, (Closed)

Created:
8 years, 7 months ago by keertip

Modified:
8 years, 7 months ago

Reviewers:
devoncarew

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

changed Run behavior http://code.google.com/p/dart/issues/detail?id=2730, added icon for Run menu item http://code.google.com/p/dart/issues/detail?id=2803 Committed: https://code.google.com/p/dart/source/detail?r=7192

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -40 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.debug.ui/plugin.xml	View	3 chunks	+3 lines, -27 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/launch/DartRunAction.java	View	1 chunk	+4 lines, -3 lines	1 comment	Download
M	editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/launch/DartRunLastAction.java	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/launch/RunPropertyTester.java	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.deploy/plugin.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/deploy/ApplicationActionBarAdvisor.java	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

devoncarew

8 years, 7 months ago (2012-04-30 21:16:32 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10270017/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/launch/DartRunAction.java
(right):

https://chromiumcodereview.appspot.com/10270017/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/launch/DartRunAction.java:99:
if (candidates.size() == 0) { // selection is neither a server of browser app
or

Expand Messages | Collapse Messages