Issue 10270007: Fixed preparser for try statement. Tiny cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10270007: Fixed preparser for try statement. Tiny cleanup. (Closed)

Created:
8 years, 7 months ago by Sven Panne

Modified:
8 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed preparser for try statement. Tiny cleanup. BUG=v8:2109 TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11468

Patch Set 2 : Incorporated review comments #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -8 lines)			Patch
	M	src/preparser.h	View	1	1 chunk	+13 lines, -2 lines	0 comments	Download
	M	src/preparser.cc	View	1	2 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM http://codereview.chromium.org/10270007/diff/1/src/preparser.h File src/preparser.h (right): http://codereview.chromium.org/10270007/diff/1/src/preparser.h#newcode474 src/preparser.h:474: class WithinWith { nit: not sure I like ...

8 years, 7 months ago (2012-04-30 12:52:32 UTC) #1

Sven Panne

8 years, 7 months ago (2012-04-30 13:02:32 UTC) #2

Landing...

http://codereview.chromium.org/10270007/diff/1/src/preparser.h
File src/preparser.h (right):

http://codereview.chromium.org/10270007/diff/1/src/preparser.h#newcode474
src/preparser.h:474: class WithinWith {
On 2012/04/30 12:52:32, Jakob wrote:
> nit: not sure I like the name... how about InsideWith?

Done.

http://codereview.chromium.org/10270007/diff/1/src/preparser.h#newcode476
src/preparser.h:476: explicit WithinWith(Scope* scope): scope_(scope) {
On 2012/04/30 12:52:32, Jakob wrote:
> nit: space before ':'

Done.

Expand Messages | Collapse Messages

Issue 10270007: Fixed preparser for try statement. Tiny cleanup. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Incorporated review comments #

Messages