Issue 10270005: Revert 134507, broke the main builders:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10270005: Revert 134507, broke the main builders: (Closed)

Created:
8 years, 7 months ago by brettw

Modified:
8 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 134507, broke the main builders: http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/28236/steps/compile/logs/stdio - Add unit_tests_run that (mostly) works for all of linux, OSX and Windows. The dependencies were retrieved with trace_inputs.py and merged with merge_isolate.py. Manual edits: - Added <(EXECUTABLE_SUFFIX) to two executables: unit_tests and xdisplaycheck. - Removed testserver.log and unit_tests.log. - Added copyright. - Removed *.db-journal files. R=rogerta@chromium.org BUG=98636 TEST= Review URL: http://codereview.chromium.org/9693023 TBR=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134508

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1107 lines)			Patch
	M	chrome/chrome_tests.gypi	View		1 chunk	+0 lines, -30 lines	0 comments	Download
	D	chrome/unit_tests.isolate	View		1 chunk	+0 lines, -1077 lines	0 comments	Download

Total messages: 2 (0 generated)

Thanks for reverting!