Issue 10270004: cocoa/bookmarks: Do not rely on Browser::tabstrip_model() accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10270004: cocoa/bookmarks: Do not rely on Browser::tabstrip_model() accessor. (Closed)

Created:
8 years, 7 months ago by tfarina

Modified:
8 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cocoa/bookmarks: Do not rely on Browser::tabstrip_model() accessor. This simplifies BookmarkAllTabsController::UpdateActiveTabPairs() function. R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134855

Patch Set 1 #

Total comments: 2

Patch Set 2 : nico review -> contents #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.mm	View	1	1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

s/By doing this, this patch greatly simplifies/This simplifies/ in the CL description. http://codereview.chromium.org/10270004/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.mm ...

8 years, 7 months ago (2012-04-30 15:23:47 UTC) #2

tfarina

8 years, 7 months ago (2012-04-30 16:59:12 UTC) #4

On 2012/04/30 15:23:47, Nico wrote:
> s/By doing this, this patch greatly simplifies/This simplifies/ in the CL
> description.
> 
Done.

http://codereview.chromium.org/10270004/diff/1/chrome/browser/ui/cocoa/bookma...
File chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.mm (right):

http://codereview.chromium.org/10270004/diff/1/chrome/browser/ui/cocoa/bookma...
chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.mm:49:
WebContents* wc = browser->GetWebContentsAt(i);
On 2012/04/30 15:23:47, Nico wrote:
> nit: The styleguide discourages abbreviations. Does `contents` work? (I know
> that the old name was wc too)

Done.

Expand Messages | Collapse Messages