Issue 10270002: Get the custom frame limping with win-aura.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10270002: Get the custom frame limping with win-aura. (Closed)

Created:
8 years, 7 months ago by Ben Goodger (Google)

Modified:
8 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Get the custom frame limping with win-aura. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134705

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+278 lines, -14 lines)			Patch
M	ui/gfx/screen_aura.cc	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
M	ui/views/views.gyp	View	1 2	2 chunks	+16 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_native_widget_helper_aura.h	View	1 2	3 chunks	+12 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_native_widget_helper_aura.cc	View	1 2	3 chunks	+15 lines, -1 line	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	ui/views/widget/native_widget_helper_aura.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/widget/native_widget_win.cc	View		2 chunks	+1 line, -8 lines	0 comments	Download
A	ui/views/widget/widget_hwnd_utils.h	View		1 chunk	+22 lines, -0 lines	0 comments	Download
A	ui/views/widget/widget_hwnd_utils.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	ui/views/widget/widget_message_filter.h	View		1 chunk	+59 lines, -0 lines	0 comments	Download
A	ui/views/widget/widget_message_filter.cc	View		1 chunk	+131 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

this has numerous bugs, but I wanted to checkpoint before I started writing a lot ...

8 years, 7 months ago (2012-04-30 20:56:08 UTC) #1

sky

8 years, 7 months ago (2012-04-30 21:15:35 UTC) #2

LGTM

http://codereview.chromium.org/10270002/diff/2006/ui/gfx/screen_aura.cc
File ui/gfx/screen_aura.cc (right):

http://codereview.chromium.org/10270002/diff/2006/ui/gfx/screen_aura.cc#newco...
ui/gfx/screen_aura.cc:26: #if defined(USE_AURA)
Can this ifdef be removed entirely?

Expand Messages | Collapse Messages