Issue 10269031: Mark default apps on ChromeOS installed from DIR_EXTERNAL_EXTENSIONS "from webstore"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10269031: Mark default apps on ChromeOS installed from DIR_EXTERNAL_EXTENSIONS "from webstore" (Closed)

Created:
8 years, 7 months ago by tbarzic

Modified:
8 years, 7 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mark default apps on ChromeOS installed from DIR_EXTERNAL_EXTENSIONS "from webstore" The default extensions should be able to load NaCl modules. This is a problem now because they aren't really distinguishable from normal extensions. To fix this, mark them as "from webstore" when they're loaded. Also, revert crrev.com/130235 as that didn't work BUG=chromium-os:28707 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134761

Patch Set 1 #

Total comments: 1

Patch Set 2 : revert #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -15 lines)			Patch
	M	chrome/browser/extensions/external_extension_provider_impl.cc	View	1	1 chunk	+5 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

https://chromiumcodereview.appspot.com/10269031/diff/1/chrome/browser/extensions/external_extension_provider_impl.cc File chrome/browser/extensions/external_extension_provider_impl.cc (right): https://chromiumcodereview.appspot.com/10269031/diff/1/chrome/browser/extensions/external_extension_provider_impl.cc#newcode337 chrome/browser/extensions/external_extension_provider_impl.cc:337: Extension::FROM_WEBSTORE))); Can you revert this change (Bill's attempted fix ...

8 years, 7 months ago (2012-05-01 19:09:30 UTC) #2

LGTM

Expand Messages | Collapse Messages