media/webm/webm_cluster_parser.cc - Issue 10269022: Add StreamParserBuffer to ChunkDemuxer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/webm/webm_cluster_parser.cc

Issue 10269022: Add StreamParserBuffer to ChunkDemuxer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/webm/webm_cluster_parser.cc

diff --git a/media/webm/webm_cluster_parser.cc b/media/webm/webm_cluster_parser.cc

index c34cd8d8743bccee4152003964c61a902be7716e..45ccd1115ef364ecc621d7db12fbbfd094d43cfc 100644

--- a/media/webm/webm_cluster_parser.cc

+++ b/media/webm/webm_cluster_parser.cc

@@ -115,7 +115,9 @@ bool WebMClusterParser::OnSimpleBlock(int track_num, int timecode,

base::TimeDelta timestamp = base::TimeDelta::FromMicroseconds(

(cluster_timecode_ + timecode) * timecode_multiplier_);

- scoped_refptr<DataBuffer> buffer = DataBuffer::CopyFrom(data, size);

+ bool is_keyframe = ((flags & 0x80) != 0);

Ami GONE FROM CHROMIUM 2012/05/01 22:34:16 IWBN if 0x80 came from some NUMERIC_CONSTANT.

Ami GONE FROM CHROMIUM 2012/05/01 22:34:16 ((flags & 0x80) != 0) == flags & 0x80 FWIW

vrk (LEFT CHROMIUM) 2012/05/02 17:24:51 Done.

vrk (LEFT CHROMIUM) 2012/05/02 17:24:51 I'm not sure where to put it, so I'm going to hold

+ scoped_refptr<StreamParserBuffer> buffer =

+ StreamParserBuffer::CopyFrom(data, size, is_keyframe);

if (track_num == video_track_num_ && video_encryption_key_id_.get()) {

buffer->SetDecryptConfig(scoped_ptr<DecryptConfig>(new DecryptConfig(