Issue 10269003: Allow a pasted-in crash URL to work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10269003: Allow a pasted-in crash URL to work. (Closed)

Created:
8 years, 7 months ago by Avi (use Gerrit)

Modified:
8 years, 7 months ago

Reviewers:
jam, Peter Kasting

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow a pasted-in crash URL to work. BUG=124843 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134610

Patch Set 2 : just "from the address bar" #

Patch Set 3 : fix win build #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	content/browser/web_contents/debug_urls.cc	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

Peter: for review: you're the omnibox master; please verify John: FYI

8 years, 7 months ago (2012-04-28 20:35:23 UTC) #1

Peter Kasting

https://chromiumcodereview.appspot.com/10269003/diff/1/content/browser/web_contents/debug_urls.cc File content/browser/web_contents/debug_urls.cc (right): https://chromiumcodereview.appspot.com/10269003/diff/1/content/browser/web_contents/debug_urls.cc#newcode17 content/browser/web_contents/debug_urls.cc:17: transition & content::PAGE_TRANSITION_FROM_ADDRESS_BAR || I think if you have ...

8 years, 7 months ago (2012-04-30 18:07:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10269003/7001

8 years, 7 months ago (2012-04-30 20:18:42 UTC) #3

Change committed as 134610