Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 10268028: Intial experiment for building dynamic images without glibc under pnacl (Closed)

Created:
8 years, 7 months ago by Robert Muth (chromium)
Modified:
8 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Intial experiment for building dynamic imaged without glibc under pnacl Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8477

Patch Set 1 #

Total comments: 38

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -0 lines) Patch
A tests/pnacl_ld_experiments/Makefile View 1 1 chunk +77 lines, -0 lines 2 comments Download
A tests/pnacl_ld_experiments/fortytwo.c View 1 1 chunk +10 lines, -0 lines 0 comments Download
A tests/pnacl_ld_experiments/hello1.c View 1 1 chunk +128 lines, -0 lines 0 comments Download
A tests/pnacl_ld_experiments/simple.h View 1 1 chunk +18 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Robert Muth (chromium)
PTAL
8 years, 7 months ago (2012-05-01 20:10:33 UTC) #1
jvoung - send to chromium...
https://chromiumcodereview.appspot.com/10268028/diff/1/tests/pnacl_ld_experiments/Makefile File tests/pnacl_ld_experiments/Makefile (right): https://chromiumcodereview.appspot.com/10268028/diff/1/tests/pnacl_ld_experiments/Makefile#newcode7 tests/pnacl_ld_experiments/Makefile:7: # which is then loaded by a regular (non-sandboxed) ...
8 years, 7 months ago (2012-05-01 23:30:49 UTC) #2
Robert Muth (chromium)
PTAL https://chromiumcodereview.appspot.com/10268028/diff/1/tests/pnacl_ld_experiments/Makefile File tests/pnacl_ld_experiments/Makefile (right): https://chromiumcodereview.appspot.com/10268028/diff/1/tests/pnacl_ld_experiments/Makefile#newcode7 tests/pnacl_ld_experiments/Makefile:7: # which is then loaded by a regular ...
8 years, 7 months ago (2012-05-02 16:18:32 UTC) #3
jvoung - send to chromium...
comments below, but LGTM https://chromiumcodereview.appspot.com/10268028/diff/1/tests/pnacl_ld_experiments/Makefile File tests/pnacl_ld_experiments/Makefile (right): https://chromiumcodereview.appspot.com/10268028/diff/1/tests/pnacl_ld_experiments/Makefile#newcode48 tests/pnacl_ld_experiments/Makefile:48: # The one above from ...
8 years, 7 months ago (2012-05-02 17:20:42 UTC) #4
jvoung - send to chromium...
https://chromiumcodereview.appspot.com/10268028/diff/7001/tests/pnacl_ld_experiments/Makefile File tests/pnacl_ld_experiments/Makefile (right): https://chromiumcodereview.appspot.com/10268028/diff/7001/tests/pnacl_ld_experiments/Makefile#newcode66 tests/pnacl_ld_experiments/Makefile:66: $(PNACL_LD) $(COMMON_FLAGS) -arch x86-32 $(LIBS) hello1.x86-32.nexe.dummy---linked.o -o $@ Actually, ...
8 years, 7 months ago (2012-05-02 17:27:27 UTC) #5
robertm
8 years, 7 months ago (2012-05-02 17:33:12 UTC) #6
https://chromiumcodereview.appspot.com/10268028/diff/1/tests/pnacl_ld_experim...
File tests/pnacl_ld_experiments/Makefile (right):

https://chromiumcodereview.appspot.com/10268028/diff/1/tests/pnacl_ld_experim...
tests/pnacl_ld_experiments/Makefile:49: INIT = crtbegin.bc $(PATH_CRT)/crt1.bc
$(PATH_CRT)/crti.bc  $(PATH_CRT)/crtdummy.bc  $(PATH_CRT)/crtbegin.bc
On 2012/05/01 23:30:49, jvoung wrote:
> 80 col

Done.

https://chromiumcodereview.appspot.com/10268028/diff/1/tests/pnacl_ld_experim...
tests/pnacl_ld_experiments/Makefile:56: #
--add-extra-dt-needed=ld-nacl-x86-32.so.1 which does not trigger the
the explore this together once the CL is in.

On 2012/05/02 17:20:42, jvoung wrote:
> Would it be posssible at the native link step to set --dynamic-linker=...?  I
> guess if you do that, you still need to call PNACL_LD manually to pass flags
to
> the linker.  With a .pso linked, it will certainly be dynamic though.
> 
> On 2012/05/02 16:18:32, Robert Muth (chromium) wrote:
> > IIRC this did not help - I think the problem is that there
> > there is not other shared lib on the command line to the linker which would
> > "force" a dynamic image.
> > 
> > On 2012/05/01 23:30:49, jvoung wrote:
> > > What happens if you build a .pexe first instead?
> > 
>

https://chromiumcodereview.appspot.com/10268028/diff/1/tests/pnacl_ld_experim...
File tests/pnacl_ld_experiments/hello1.c (right):

https://chromiumcodereview.appspot.com/10268028/diff/1/tests/pnacl_ld_experim...
tests/pnacl_ld_experiments/hello1.c:1: #include <unistd.h>
On 2012/05/01 23:30:49, jvoung wrote:
> Copyright notice.

Done.

https://chromiumcodereview.appspot.com/10268028/diff/1/tests/pnacl_ld_experim...
tests/pnacl_ld_experiments/hello1.c:72: myprint(buffer);
On 2012/05/01 23:30:49, jvoung wrote:
> perhaps print "tdata1 (expecting 1): " first, same with "tdata2 (expecting 3):
"

Done.

https://chromiumcodereview.appspot.com/10268028/diff/7001/tests/pnacl_ld_expe...
File tests/pnacl_ld_experiments/Makefile (right):

https://chromiumcodereview.appspot.com/10268028/diff/7001/tests/pnacl_ld_expe...
tests/pnacl_ld_experiments/Makefile:66: $(PNACL_LD) $(COMMON_FLAGS) -arch x86-32
  $(LIBS) hello1.x86-32.nexe.dummy---linked.o -o $@
yes, not sure whether hello1.x86-32.nexe will still build without it, will
explore this in the next CL

On 2012/05/02 17:27:27, jvoung wrote:
> Actually, so the crtbegin.o and crtend.o mentioned above should really be down
> here, right?

Powered by Google App Engine
This is Rietveld 408576698