Issue 10268027: Revert 134740 - Root window wasn't shown in browser_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10268027: Revert 134740 - Root window wasn't shown in browser_test. (Closed)

Created:
8 years, 7 months ago by kkania

Modified:
8 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 134740 - Root window wasn't shown in browser_test. Broke browser_tests on ChromiumOS bots. BUG=115967 TEST=none Review URL: http://codereview.chromium.org/10273023 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134756

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+13 lines, -5 lines)			Patch
chrome/browser/chrome_browser_main.cc	View	3 chunks	+13 lines, -0 lines	0 comments	Download
chrome/browser/chrome_browser_main_extra_parts_ash.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
chrome/browser/chrome_browser_main_extra_parts_ash.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kkania

8 years, 7 months ago (2012-05-01 20:08:20 UTC) #2

From Linux ChromiumOS Tests 2 bot:

[ RUN      ] PrintPreviewWebUITest.TestPrinterList
[1901:1901:0501/122038:35111099:WARNING:zygote_host_impl_linux.cc(154)] Running
without the SUID sandbox! See
http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more
information on developing with the sandbox on.
	base::debug::StackTrace::StackTrace() [0x7f5d8d8a803e]
	base::(anonymous namespace)::StackDumpSignalHandler() [0x7f5d8d8ea0f9]
	0x7f5d85e59af0
	ash::Shell::GetRootWindow() [0x7f5d8acd1339]
	ChromeBrowserMainExtraPartsAsh::PreMainMessageLoopStart() [0x1bfe8f9]
	ChromeBrowserMainParts::PreMainMessageLoopStart() [0x1bf6f9e]
	ChromeBrowserMainPartsChromeos::PreMainMessageLoopStart() [0x1b90ad4]
	content::BrowserMainLoop::MainMessageLoopStart() [0x7f5d8b5d7866]
	(anonymous namespace)::BrowserMainRunnerImpl::Initialize() [0x7f5d8b5d9bc0]
	BrowserMain() [0x7f5d8b5d6f57]
	BrowserTestBase::SetUp() [0x1a5f08c]
	InProcessBrowserTest::SetUp() [0x14d5e8c]
	testing::Test::Run() [0x1513cb2]
	testing::TestInfo::Run() [0x1513e0a]
	testing::TestCase::Run() [0x1513f57]
	testing::internal::UnitTestImpl::RunAllTests() [0x15141fd]
	testing::UnitTest::Run() [0x1512c43]
	base::TestSuite::Run() [0x14e9548]
	ChromeTestLauncherDelegate::RunTestSuite() [0x980d9e]
	test_launcher::LaunchTests() [0xa3fe74]
	main [0x980e09]
	0x7f5d85e44c4d
	0x4c06c9

Expand Messages | Collapse Messages