gdata: Remove use of FindEntryByPathAsync() from gdata_file_system_proxy.cc

gdata: Remove use of FindEntryByPathAsync() from gdata_file_system_proxy.cc

Instead use GetFileInfoByPathAsync() and ReadDirectoryByPathAsync().
This is in preparation for making FindEntryByPathAsync() private.

BUG=chromium-os:30251
TEST=gdata in the file manager works as before

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134770

[satorux1, 2012-05-01 06:55:49]

These are the last callers of FindEntryByPathAsync(). Will make it private in
the next patch.

[achuithb, 2012-05-01 09:21:44]

http://codereview.chromium.org/10268023/diff/4002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc (right):

http://codereview.chromium.org/10268023/diff/4002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc:60: void
GDataGDataEntryProtoToFileUtilProxyEntry(
GDataGData? I think one GData is sufficient?

This method should just return FileUtilProxyEntry. 

I don't think you need the additional methods
GDataDirectoryProtoToFileUtilProxyEntry/GDataFileProtoToFileUtilProxyEntry. 

In OnReadDirectory, you can directly call
entries.push_back(GDataEntryProtoToFileUtilProxyEntry(proto.gdata_entry()));

http://codereview.chromium.org/10268023/diff/4002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc:68:
entry->last_modified_time = file_info.last_modified;
You should just set entry->is_directory here from file_info.is_directory.

[satorux1, 2012-05-01 17:24:31]

http://codereview.chromium.org/10268023/diff/4002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc (right):

http://codereview.chromium.org/10268023/diff/4002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc:60: void
GDataGDataEntryProtoToFileUtilProxyEntry(
On 2012/05/01 09:21:44, achuith.bhandarkar wrote:
> GDataGData? I think one GData is sufficient?

Good catch! Fixed.


> This method should just return FileUtilProxyEntry. 
> 
> I don't think you need the additional methods

You are absolutely right. Fixed.


> GDataDirectoryProtoToFileUtilProxyEntry/GDataFileProtoToFileUtilProxyEntry. 
> 
> In OnReadDirectory, you can directly call
> entries.push_back(GDataEntryProtoToFileUtilProxyEntry(proto.gdata_entry()));

http://codereview.chromium.org/10268023/diff/4002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc:68:
entry->last_modified_time = file_info.last_modified;
On 2012/05/01 09:21:44, achuith.bhandarkar wrote:
> You should just set entry->is_directory here from file_info.is_directory.

The code was so bad. Good to have a great code reviewer. :)

[achuithb, 2012-05-01 18:55:56]

On 2012/05/01 17:24:31, satorux1 wrote:
>
http://codereview.chromium.org/10268023/diff/4002/chrome/browser/chromeos/gda...
> File chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc (right):
> 
>
http://codereview.chromium.org/10268023/diff/4002/chrome/browser/chromeos/gda...
> chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc:60: void
> GDataGDataEntryProtoToFileUtilProxyEntry(
> On 2012/05/01 09:21:44, achuith.bhandarkar wrote:
> > GDataGData? I think one GData is sufficient?
> 
> Good catch! Fixed.
> 
> 
> > This method should just return FileUtilProxyEntry. 
> > 
> > I don't think you need the additional methods
> 
> You are absolutely right. Fixed.
> 
> 
> > GDataDirectoryProtoToFileUtilProxyEntry/GDataFileProtoToFileUtilProxyEntry. 
> > 
> > In OnReadDirectory, you can directly call
> > entries.push_back(GDataEntryProtoToFileUtilProxyEntry(proto.gdata_entry()));
> 
>
http://codereview.chromium.org/10268023/diff/4002/chrome/browser/chromeos/gda...
> chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc:68:
> entry->last_modified_time = file_info.last_modified;
> On 2012/05/01 09:21:44, achuith.bhandarkar wrote:
> > You should just set entry->is_directory here from file_info.is_directory.
> 
> The code was so bad. Good to have a great code reviewer. :)

It wasn't so bad! You're harsh on yourself. You've done more than your part in
doing good code reviews in drive and maintaining code quality.

lgtm! Thanks again for all the cleanup efforts.