Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: tools/testing/perf_testing/run_perf_tests.py

Issue 10267016: Skip crashing test on Chrome in Windows. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/perf_testing/run_perf_tests.py
===================================================================
--- tools/testing/perf_testing/run_perf_tests.py (revision 7170)
+++ tools/testing/perf_testing/run_perf_tests.py (working copy)
@@ -568,12 +568,12 @@
return str
# TODO(vsm): This is a hack to skip breaking tests. Triage this
- # failure properly. The modify suite fails on 32-bit chrome on
- # the mac.
+ # failure properly. The modify suite fails on 32-bit chrome, which
+ # is the default on mac and win.
@staticmethod
def get_valid_dromaeo_tags():
tags = [tag for (tag, _) in DromaeoTester.DROMAEO_BENCHMARKS.values()]
- if platform.system() == 'Darwin':
+ if platform.system() == 'Darwin' or platform.system() == 'Windows':
tags.remove('modify')
return tags
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698