Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 10267005: Makes the new tab button work in touch mode. (Closed)

Created:
8 years, 7 months ago by sky
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Makes the new tab button work in touch mode. BUG=125429 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
8 years, 7 months ago (2012-04-30 00:30:43 UTC) #1
Ben Goodger (Google)
8 years, 7 months ago (2012-04-30 01:45:15 UTC) #2
LGTM

On Sun, Apr 29, 2012 at 5:30 PM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Makes the new tab button work in touch mode.
>
> BUG=125429
> TEST=none
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10267005/<http://codereview.chromium.org/102...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/ui/views/tabs/**tab_strip.cc
>
>
> Index: chrome/browser/ui/views/tabs/**tab_strip.cc
> diff --git a/chrome/browser/ui/views/**tabs/tab_strip.cc
> b/chrome/browser/ui/views/**tabs/tab_strip.cc
> index 449fe44d7f546ced6f35de5243087a**38365f40c0..**
> 25b4f2c382088f255e625fa12644ef**eab4633163 100644
> --- a/chrome/browser/ui/views/**tabs/tab_strip.cc
> +++ b/chrome/browser/ui/views/**tabs/tab_strip.cc
> @@ -1076,6 +1076,13 @@ views::View* TabStrip::**GetEventHandlerForPoint(const
> gfx::Point& point) {
>         return tab_at(i);
>     }
>   } else {
> +    if (newtab_button_->visible()) {
> +      gfx::Point newtab_button_point(point);
> +      View::ConvertPointToView(this, newtab_button_,
> &newtab_button_point);
> +      if (newtab_button_->HitTest(**newtab_button_point))
> +        return newtab_button_->**GetEventHandlerForPoint(**
> newtab_button_point);
> +    }
> +
>     int active_tab_index = touch_layout_->active_index();
>     if (active_tab_index != -1) {
>       Tab* tab = FindTabForEvent(point, active_tab_index, -1);
>
>
>

Powered by Google App Engine
This is Rietveld 408576698