chrome/browser/ui/panels/panel_drag_gtk.h - Issue 10266021: GTK Panels - fix crash when clicking on titlebar to restore a panel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_drag_gtk.h

Issue 10266021: GTK Panels - fix crash when clicking on titlebar to restore a panel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add extra drag state to make code clearer Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/panel_drag_gtk.h

diff --git a/chrome/browser/ui/panels/panel_drag_gtk.h b/chrome/browser/ui/panels/panel_drag_gtk.h

index 6ca655a5856572a0c5d1bf5badf74e99c3e2ce2e..4341b7f1fd525f5adbfea0b68b496cf71a50bb41 100644

--- a/chrome/browser/ui/panels/panel_drag_gtk.h

+++ b/chrome/browser/ui/panels/panel_drag_gtk.h

@@ -48,7 +48,8 @@ class PanelDragGtk {

enum DragState {

NOT_DRAGGING,

- DRAG_IN_PROGRESS,

+ DRAG_CAN_START, // mouse pressed

+ DRAG_IN_PROGRESS, // mouse moved beyond drag threshold

DRAG_ENDED_WAITING_FOR_MOUSE_RELEASE

};

« no previous file with comments | « no previous file | chrome/browser/ui/panels/panel_drag_gtk.cc » ('j') | no next file with comments »