Issue 10266021: GTK Panels - fix crash when clicking on titlebar to restore a panel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10266021: GTK Panels - fix crash when clicking on titlebar to restore a panel. (Closed)

Created:
8 years, 7 months ago by jennb

Modified:
8 years, 7 months ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews, jennb, jianli, dcheng, Andrei

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GTK Panels - fix crash when clicking on titlebar to restore a panel. This bug was introduced by r10170037 which waited until mouse was released to truly end a grab. BUG=crash when clicking on titlebar to restore a minimized panel TEST=minimize a panel. click on titlebar to restore. verify no crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134655

Patch Set 1 #

Patch Set 2 : add extra drag state to make code clearer #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -28 lines)			Patch
	M	chrome/browser/ui/panels/panel_drag_gtk.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/panels/panel_drag_gtk.cc	View	1	9 chunks	+44 lines, -27 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jennb

Bug was caught by dcheck in OnMouseMoveEvent. I didn't release the grabs if mouse did ...

8 years, 7 months ago (2012-04-30 23:10:16 UTC) #1

Even LGTMer :-)

Expand Messages | Collapse Messages