Add the --disable-off-store-extension-install switch.

chrome/browser/download/download_crx_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Download code which handles CRX files (extensions, themes, apps, ...).
 
 #include "chrome/browser/download/download_util.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_install_ui.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/webstore_installer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_notification_types.h"
+#include "chrome/common/extensions/switch_utils.h"
 #include "content/public/browser/download_item.h"
 #include "content/public/browser/notification_service.h"
 
 using content::BrowserThread;
 using content::DownloadItem;
 
 namespace download_crx_util {
 
 namespace {
 
@@ skipping 19 matching lines @@
 }
 
 }  // namespace
 
 // Tests can call this method to inject a mock ExtensionInstallUI
 // to be used to confirm permissions on a downloaded CRX.
 void SetMockInstallUIForTesting(ExtensionInstallUI* mock_ui) {
   mock_install_ui_for_testing = mock_ui;
 }
 
+bool ShouldOpenExtensionDownload(const DownloadItem& download_item) {
+  if (extensions::switch_utils::IsOffStoreInstallEnabled() &&

[benjhayden, 2012/04/30 19:26:12]

Can you just return this condition directly?

[benjhayden, 2012/04/30 19:26:12]

Do you anticipate needing to call IsOffStoreInstallEnabled() any other places?
If not, why not just inline it here? That seems to be a more common practice
than creating a new file-pair to wrap a single tiny static bool().

[Aaron Boodman, 2012/04/30 20:23:41]

I think it reads more clearly to use a traditional if statement when the line
wraps. I'll change it if you feel strongly since this is downloads/.

[Aaron Boodman, 2012/04/30 20:23:41]

Yes.
I'm trying something new here.

Guidance is that we should be able to easily kill new features if they get
delayed during launch review. It's not easy to do that with the traditional
switch approach because you have to negate the check in many places. The idea is
that in order to switch the feature from default-on to default-off, I just need
to change switches file and switch_utils.*.

+      WebstoreInstaller::GetAssociatedApproval(download_item)) {
+    return true;
+  } else {
+    return false;
+  }
+}
+
 scoped_refptr<CrxInstaller> OpenChromeExtension(
     Profile* profile,
     const DownloadItem& download_item) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   ExtensionService* service = profile->GetExtensionService();
   CHECK(service);
 
   scoped_refptr<CrxInstaller> installer(
       CrxInstaller::Create(
@@ skipping 17 matching lines @@
       installer->set_original_download_url(download_item.GetOriginalUrl());
     installer->set_allow_silent_install(is_gallery_download);
     installer->set_install_cause(extension_misc::INSTALL_CAUSE_USER_DOWNLOAD);
     installer->InstallCrx(download_item.GetFullPath());
   }
 
   return installer;
 }
 
 }  // namespace download_crx_util