Issue 10266003: NaCl: Move sel_ldr_launcher_chrome.cc into the Chromium repo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10266003: NaCl: Move sel_ldr_launcher_chrome.cc into the Chromium repo (Closed)

Created:
8 years, 7 months ago by Mark Seaborn

Modified:
8 years, 7 months ago

Reviewers:
sehr (please use chromium)

CC:
chromium-reviews, bbudge

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Move sel_ldr_launcher_chrome.cc into the Chromium repo This will allow the launch_nacl_process() callback to be simplified by removing unused arguments. But for now, I have left sel_ldr_launcher_chrome.cc unchanged except to change its use of namespaces. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2750 TEST=nacl_integration etc. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134552

Patch Set 1 #

Patch Set 2 : Fix namespace #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -3 lines)			Patch
M	ppapi/native_client/src/trusted/plugin/plugin.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.h	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A	ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View		2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages