Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 10264027: Revert 134667 - Add unit_tests_run that (mostly) works for all of linux, OSX and Windows. (Closed)

Created:
8 years, 7 months ago by Evan Stade
Modified:
8 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 134667 - Add unit_tests_run that (mostly) works for all of linux, OSX and Windows. it broke the linux x64 bulder. > Revert r134607 "Revert r134508 "Revert 134507, broke the main builders:"" > Overall, this reapplies r134507. > The dependencies were retrieved with trace_inputs.py and merged with merge_isolate.py. > Manual edits: > - Added <(EXECUTABLE_SUFFIX) to two executables: unit_tests and xdisplaycheck. > - Removed testserver.log and unit_tests.log. > - Added copyright. > - Removed *.db-journal files. > TBR=rogerta@chromium.org > BUG=98636 > TEST= > Review URL: http://codereview.chromium.org/10269019 TBR=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1107 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/unit_tests.isolate View 1 chunk +0 lines, -1077 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
8 years, 7 months ago (2012-05-01 03:54:52 UTC) #1
M-A Ruel
8 years, 7 months ago (2012-05-01 12:27:19 UTC) #2
Thanks for reverting, this CL is a pain.

Powered by Google App Engine
This is Rietveld 408576698