Change CreateTemporaryDirInDir to be "more unique"

Change CreateTemporaryDirInDir to be "more unique"

This change includes a process id in the synthesized temp dir
names, so that created directories will be more unique across
the system when you're running a bunch of base-using processes at
once (e.g., in the layout tests).

BUG=125678
R=brettw@chromium.org

[brettw, 2012-05-01 04:51:11]

lgtm

http://codereview.chromium.org/10264026/diff/1/base/file_util_win.cc
File base/file_util_win.cc (right):

http://codereview.chromium.org/10264026/diff/1/base/file_util_win.cc#newcode564
base/file_util_win.cc:564: new_dir_name.append(FILE_PATH_LITERAL("_"));
I'd do "new_dir_name.push_back('_');" which will work regardless of string type
and is also more efficient.

[Dirk Pranke, 2012-05-01 19:01:23]

http://codereview.chromium.org/10264026/diff/1/base/file_util_win.cc
File base/file_util_win.cc (right):

http://codereview.chromium.org/10264026/diff/1/base/file_util_win.cc#newcode564
base/file_util_win.cc:564: new_dir_name.append(FILE_PATH_LITERAL("_"));
On 2012/05/01 04:51:11, brettw wrote:
> I'd do "new_dir_name.push_back('_');" which will work regardless of string
type
> and is also more efficient.

Just goes to show how weak my c++ is :). Done.

[commit-bot: I haz the power, 2012-05-01 19:06:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/10264026/1