Issue 10264012: Move WaitUntilWifiNetworkAvailable and GetServicePath to pyauto so it can be reached from autotest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10264012: Move WaitUntilWifiNetworkAvailable and GetServicePath to pyauto so it can be reached from autotest (Closed)

Created:
8 years, 7 months ago by krisr

Modified:
8 years, 7 months ago

Reviewers:
dtu, stanleyw

CC:
chromium-reviews, stanleyw

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move WaitUntilWifiNetworkAvailable and GetServicePath to pyauto so it can be reached from autotest BUG=None Test=Ran it Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134591

Patch Set 2 : #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -65 lines)			Patch
	M	chrome/test/pyautolib/chromeos_network.py	View	1	1 chunk	+0 lines, -65 lines	0 comments	Download
	M	chrome/test/pyautolib/pyauto.py	View	1	2 chunks	+65 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stanleyw

One comment, otherwise LGTM https://chromiumcodereview.appspot.com/10264012/diff/1/chrome/test/pyautolib/chromeos_network.py File chrome/test/pyautolib/chromeos_network.py (left): https://chromiumcodereview.appspot.com/10264012/diff/1/chrome/test/pyautolib/chromeos_network.py#oldcode291 chrome/test/pyautolib/chromeos_network.py:291: def GetConnectedWifi(self): You might as ...

8 years, 7 months ago (2012-04-30 19:46:51 UTC) #2

dtu

8 years, 7 months ago (2012-04-30 21:26:05 UTC) #3

LGTM with a quick comment.

https://chromiumcodereview.appspot.com/10264012/diff/4001/chrome/test/pyautol...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10264012/diff/4001/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:4237: """Returns the SSID of the currently
connected wifi network.
Add "on ChromeOS" or something like that. Same with the other one.

Expand Messages | Collapse Messages

Issue 10264012: Move WaitUntilWifiNetworkAvailable and GetServicePath to pyauto so it can be reached from autotest (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages