Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: tools/testing/dart/drt_updater.dart

Issue 10264005: Suppress get_drt/dartium download if an executable is provided via flag (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Added comment Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/drt_updater.dart
diff --git a/tools/testing/dart/drt_updater.dart b/tools/testing/dart/drt_updater.dart
index 9c3a6d436d03cbcc767796f7b6ad80666f2ab6b8..4a42482e71b61fe7c6f738ea9ff4dba54eda6655 100644
--- a/tools/testing/dart/drt_updater.dart
+++ b/tools/testing/dart/drt_updater.dart
@@ -53,14 +53,17 @@ class _DartiumUpdater {
_DartiumUpdater _dumpRenderTreeUpdater;
_DartiumUpdater _dartiumUpdater;
-_DartiumUpdater runtimeUpdater(String runtime) {
- if (runtime == 'drt') {
+_DartiumUpdater runtimeUpdater(Map configuration) {
+ String runtime = configuration['runtime'];
+ if (runtime == 'drt' && configuration['drt'] == '') {
+ // Download the default DumpRenderTree from Google Storage.
if (_dumpRenderTreeUpdater === null) {
_dumpRenderTreeUpdater = new _DartiumUpdater('DumpRenderTree',
'get_drt.py');
}
return _dumpRenderTreeUpdater;
- } else if (runtime == 'dartium') {
+ } else if (runtime == 'dartium' && configuration['dartium'] == '') {
+ // Download the default Dartium from Google Storage.
if (_dartiumUpdater === null) {
_dartiumUpdater = new _DartiumUpdater('Dartium Chrome', 'get_drt.py',
'--dartium');
« no previous file with comments | « no previous file | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698