Generate a browser action for any extension which doesn't have a browser or

chrome/common/extensions/extension.cc

Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index adbaa0a3a2f0a18c23cf72884fec9323ec7de0e4..77acde5c1bf4a0488f7434feb9b604f261d9052e 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -2332,6 +2332,22 @@ bool Extension::LoadBrowserAction(string16* error) {
   return true;
 }
 
+void Extension::GenerateBrowserActionIfPossible() {

[Aaron Boodman, 2012/04/30 03:27:22]

IfNecessary?

[not at google - send to devlin, 2012/04/30 04:48:22]

Well, IfPossible is I think more accurate. I like the

if (!browser_action)
  GenerateBrowserAction();

logic rather than just always calling "GenerateBrowserActionIfNecessary()".  And
yeah, the only reason why a browser action wouldn't be generated is if they
aren't supported by the extension type, hence "IfPossible".  Actually I could
have left that suffix off entirely, it's kind of an implementation detail.

+  // It only makes sense to generate brower actions for extensions that are
+  // shown in chrome://extensions.
+  if (!ShouldDisplayInExtensionSettings())
+    return;
+
+  // Hosted and platform apps are shown in extension settings, but we don't
+  // want to generate browser actions for those either, since they can't define
+  // browser actions.
+  if (is_app())
+    return;
+
+  browser_action_.reset(new ExtensionAction(id()));
+  browser_action_->SetTitle(ExtensionAction::kDefaultTabId, name());
+}
+
 bool Extension::LoadFileBrowserHandlers(string16* error) {
   if (!manifest_->HasKey(keys::kFileBrowserHandlers))
     return true;
@@ -3081,6 +3097,12 @@ bool Extension::InitFromValue(int flags, string16* error) {
   if (!LoadThemeFeatures(error))
     return false;
 
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+        switches::kEnableBrowserActionsForAll) &&
+      !browser_action()) {
+    GenerateBrowserActionIfPossible();
+  }
+
   if (HasMultipleUISurfaces()) {
     *error = ASCIIToUTF16(errors::kOneUISurfaceOnly);
     return false;
@@ -3645,6 +3667,33 @@ ExtensionInfo::ExtensionInfo(const DictionaryValue* manifest,
     extension_manifest.reset(manifest->DeepCopy());
 }
 
+bool Extension::ShouldDisplayInExtensionSettings() const {
+  // Don't show for themes since the settings UI isn't really useful for them.
+  if (is_theme())
+    return false;
+
+  // Don't show component extensions because they are only extensions as an
+  // implementation detail of Chrome.
+  if (location() == Extension::COMPONENT &&
+      !CommandLine::ForCurrentProcess()->HasSwitch(
+        switches::kShowComponentExtensionOptions))
+    return false;
+
+  // Always show unpacked extensions and apps.
+  if (location() == Extension::LOAD)
+    return true;
+
+  // Unless they are unpacked, never show hosted apps. Note: We intentionally
+  // show packaged apps and platform apps because there are some pieces of
+  // functionality that are only available in chrome://extensions/ but which
+  // are needed for packaged and platform apps. For example, inspecting
+  // background pages. See http://crbug.com/116134.
+  if (is_hosted_app())
+    return false;
+
+  return true;
+}
+
 ExtensionInfo::~ExtensionInfo() {}
 
 Extension::RuntimeData::RuntimeData() {}