chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc - Issue 1026383003: <webview>: make context menus cancellable using JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

Issue 1026383003: <webview>: make context menus cancellable using JS API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from yoz@ Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | chrome/common/extensions/api/chrome_web_view_internal.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

index 89e6dae808efc3a05d7d43febc2ba398487c7154..ec4208d2096a6ea7cfaaac54eb91b7dedc633de5 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

@@ -54,7 +54,7 @@ bool ChromeWebViewGuestDelegate::HandleContextMenu(

args->Set(webview::kContextMenuItems, items.release());

args->SetInteger(webview::kRequestId, request_id);

web_view_guest()->DispatchEventToView(

- new GuestViewBase::Event(webview::kEventContextMenu, args.Pass()));

+ new GuestViewBase::Event(webview::kEventContextMenuShow, args.Pass()));

return true;

}