Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Unified Diff: chrome/browser/ui/webui/plugins_ui.cc

Issue 10263022: Move version metadata from PluginGroup into PluginInstaller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/pdf/pdf_unsupported_feature.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/plugins_ui.cc
diff --git a/chrome/browser/ui/webui/plugins_ui.cc b/chrome/browser/ui/webui/plugins_ui.cc
index 34aef3c276292e699b7ade6ad68e03eab9d5307e..a1aac367e9546e68ea1f489a78fc3580033b10a5 100644
--- a/chrome/browser/ui/webui/plugins_ui.cc
+++ b/chrome/browser/ui/webui/plugins_ui.cc
@@ -426,16 +426,17 @@ void PluginsDOMHandler::PluginsLoaded(PluginFinder* plugin_finder,
group_data->SetString("id", group.identifier());
group_data->SetString("description", active_plugin->desc);
group_data->SetString("version", active_plugin->version);
- group_data->SetBoolean("critical", group.IsVulnerable(*active_plugin));
- std::string update_url;
#if defined(ENABLE_PLUGIN_INSTALLATION)
PluginInstaller* installer =
plugin_finder->FindPluginWithIdentifier(group.identifier());
- if (installer)
- update_url = installer->plugin_url().spec();
+ if (installer) {
+ bool out_of_date = installer->GetSecurityStatus(*active_plugin) ==
+ PluginInstaller::SECURITY_STATUS_OUT_OF_DATE;
+ group_data->SetBoolean("critical", out_of_date);
+ group_data->SetString("update_url", installer->plugin_url().spec());
+ }
#endif
- group_data->SetString("update_url", update_url);
std::string enabled_mode;
if (all_plugins_enabled_by_policy) {
« no previous file with comments | « chrome/browser/ui/pdf/pdf_unsupported_feature.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698