Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1894)

Unified Diff: content/public/browser/download_manager_delegate.h

Issue 10263019: DownloadManagerDelegate::ShouldCompleteDownload(callback) (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: merge Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/download_item.h ('k') | content/public/browser/download_manager_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/download_manager_delegate.h
diff --git a/content/public/browser/download_manager_delegate.h b/content/public/browser/download_manager_delegate.h
index 641920ff3ba0faa34527facd01f98a34bcfe020c..21b09024eab94e7c662ff381b7b0ada793f71faa 100644
--- a/content/public/browser/download_manager_delegate.h
+++ b/content/public/browser/download_manager_delegate.h
@@ -68,14 +68,17 @@ class CONTENT_EXPORT DownloadManagerDelegate {
// Tests if a file type should be opened automatically.
virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path);
- // Allows the delegate to override completion of the download. If this
- // function returns false, the download completion is delayed and the
- // delegate is responsible for making sure that
- // DownloadItem::MaybeCompleteDownload is called at some point in the
- // future. Note that at that point this function will be called again,
- // and is responsible for returning true when it really is ok for the
- // download to complete.
- virtual bool ShouldCompleteDownload(DownloadItem* item);
+ // Allows the delegate to delay completion of the download. This function
+ // will either return true (in which case the download is ready to complete)
+ // or arrange for complete_callback to be called at some point in the future
+ // when the download is ready to complete.
+ //
+ // ShouldCompleteDownload() may be called multiple times; if it is, only the
+ // last callback specified (while the delegate is delaying completion) will be
+ // run. Calls made after the callback is run are guaranteed to return true.
+ virtual bool ShouldCompleteDownload(
+ DownloadItem* item,
+ const base::Closure& complete_callback);
// Allows the delegate to override opening the download. If this function
// returns false, the delegate needs to call
« no previous file with comments | « content/public/browser/download_item.h ('k') | content/public/browser/download_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698