Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: vm/flow_graph_compiler_x64.cc

Issue 10262033: Fix stack pointer reset bug in entry to catch blocks. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/code_generator_x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/flow_graph_compiler_x64.cc
===================================================================
--- vm/flow_graph_compiler_x64.cc (revision 7165)
+++ vm/flow_graph_compiler_x64.cc (working copy)
@@ -1140,8 +1140,11 @@
// popping arguments has not been run.
const intptr_t locals_space_size = StackSize() * kWordSize;
ASSERT(locals_space_size >= 0);
- __ movq(RSP, RBP);
- __ subq(RSP, Immediate(locals_space_size));
+ if (locals_space_size == 0) {
+ __ movq(RSP, RBP);
+ } else {
+ __ leaq(RSP, Address(RBP, -locals_space_size));
+ }
ASSERT(!comp->exception_var().is_captured());
ASSERT(!comp->stacktrace_var().is_captured());
« no previous file with comments | « vm/code_generator_x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698