Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6783)

Unified Diff: chrome/browser/infobars/infobar_tab_helper.cc

Issue 10262026: A few small tweaks based on further analysis of GoogleURLTracker: (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/google/google_url_tracker.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/infobars/infobar_tab_helper.cc
===================================================================
--- chrome/browser/infobars/infobar_tab_helper.cc (revision 134398)
+++ chrome/browser/infobars/infobar_tab_helper.cc (working copy)
@@ -39,7 +39,9 @@
}
for (size_t i = 0; i < infobars_.size(); ++i) {
- if (GetInfoBarDelegateAt(i)->EqualsDelegate(delegate)) {
+ InfoBarDelegate* delegate_at_i = GetInfoBarDelegateAt(i);
Ilya Sherman 2012/05/02 03:52:43 nit: Perhaps use an iterator instead of creating t
+ if (delegate_at_i->EqualsDelegate(delegate)) {
+ DCHECK_NE(delegate_at_i, delegate);
delegate->InfoBarClosed();
return;
}
« no previous file with comments | « chrome/browser/google/google_url_tracker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698