A few small tweaks based on further analysis of GoogleURLTracker:

A few small tweaks based on further analysis of GoogleURLTracker:

* Go ahead and redo even pending searches.  If I have a pending search in tab B and say "yes, retarget my Google URL" in tab A, it's reasonable to retarget tab B instead of letting it proceed with the old URL.
* Make the code safe even if AddInfoBar() fails for some reason.  We already deleted the infobar and removed it from the GoogleURLTracker's map, but the existing code briefly accessed a member after "this" had been deleted.  Simple fix.
* While I'm at it, also DCHECK() against adding the same infobar twice in AddInfoBar() itself.  This won't happen with the existing code, but I managed to introduce such a problem while doing some other experiments.

BUG=110158
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135054

[Ilya Sherman, 2012-05-02 03:52:43]

LGTM

https://chromiumcodereview.appspot.com/10262026/diff/1/chrome/browser/infobar...
File chrome/browser/infobars/infobar_tab_helper.cc (right):

https://chromiumcodereview.appspot.com/10262026/diff/1/chrome/browser/infobar...
chrome/browser/infobars/infobar_tab_helper.cc:42: InfoBarDelegate* delegate_at_i
= GetInfoBarDelegateAt(i);
nit: Perhaps use an iterator instead of creating this temporary variable (unless
it's important to use GetInfoBarDelegateAt() here)?