Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 10261034: Per issue 125757, added more test cases to be monitored in the layout test (Closed)

Created:
8 years, 7 months ago by imasaki1
Modified:
8 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Per issue 125757, added more test cases to be monitored in the layout test anazlyzer. Also, changed CSV format to use double quotations for seperators instead of commas. BUG=125757 TEST=make sure layout analzyer runs with new test cases Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135246

Patch Set 1 #

Total comments: 2

Patch Set 2 : Enable recursion and reduce the number of entries in test case CSV file. #

Total comments: 10

Patch Set 3 : Modified based on CR comments and removed svg files from monitoring. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M media/tools/layout_tests/layouttest_analyzer.py View 1 1 chunk +1 line, -1 line 0 comments Download
M media/tools/layout_tests/layouttests.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/tools/layout_tests/testname/media.csv View 1 2 2 chunks +7 lines, -6 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
imasaki1
This change will enable monitoring layout test cases you asked for. I used to declare ...
8 years, 7 months ago (2012-05-01 20:01:50 UTC) #1
imasaki1
After discussion with ddorwin and scherkus, I have decided to enable recursion.
8 years, 7 months ago (2012-05-01 21:26:45 UTC) #2
ddorwin
Thanks for making this recursive. A few small comments and added scherkus to make sure ...
8 years, 7 months ago (2012-05-01 22:32:37 UTC) #3
scherkus (not reviewing)
https://chromiumcodereview.appspot.com/10261034/diff/2001/media/tools/layout_tests/layouttest_analyzer.py File media/tools/layout_tests/layouttest_analyzer.py (right): https://chromiumcodereview.appspot.com/10261034/diff/2001/media/tools/layout_tests/layouttest_analyzer.py#newcode146 media/tools/layout_tests/layouttest_analyzer.py:146: recursion = True didn't you mention there were performance ...
8 years, 7 months ago (2012-05-02 00:50:54 UTC) #4
imasaki1
PTAL? thanks. https://chromiumcodereview.appspot.com/10261034/diff/2001/media/tools/layout_tests/layouttest_analyzer.py File media/tools/layout_tests/layouttest_analyzer.py (right): https://chromiumcodereview.appspot.com/10261034/diff/2001/media/tools/layout_tests/layouttest_analyzer.py#newcode146 media/tools/layout_tests/layouttest_analyzer.py:146: recursion = True On 2012/05/02 00:50:55, scherkus ...
8 years, 7 months ago (2012-05-03 23:31:14 UTC) #5
scherkus (not reviewing)
8 years, 7 months ago (2012-05-03 23:54:55 UTC) #6
lgtm

https://chromiumcodereview.appspot.com/10261034/diff/9001/media/tools/layout_...
File media/tools/layout_tests/testname/media.csv (right):

https://chromiumcodereview.appspot.com/10261034/diff/9001/media/tools/layout_...
media/tools/layout_tests/testname/media.csv:26: platform/chromium/media/,
nit: this isn't something we really need to worry about now, but this file isn't
really a CSV but rather a newline delimited file

it seems odd to require trailing commas

Powered by Google App Engine
This is Rietveld 408576698