Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6452)

Unified Diff: chrome/test/functional/special_tabs.py

Issue 10261030: Remove a url check from testSpecialURLTabs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/special_tabs.py
diff --git a/chrome/test/functional/special_tabs.py b/chrome/test/functional/special_tabs.py
index 6f008c8b83e1591018e1c7901900ca815c3f333f..4b5dc291e5bd472e9f59ea670514294897fc7066 100755
--- a/chrome/test/functional/special_tabs.py
+++ b/chrome/test/functional/special_tabs.py
@@ -41,7 +41,6 @@ class SpecialTabsTest(pyauto.PyUITest):
'chrome://appcache-internals': { 'title': 'AppCache Internals' },
'chrome://blob-internals': { 'title': 'Blob Storage Internals' },
'chrome://feedback': {},
- 'chrome://feedback/#0': { 'title': 'Feedback' },
'chrome://chrome-urls': { 'title': 'Chrome URLs' },
'chrome://crashes': { 'title': 'Crashes' },
'chrome://credits': { 'title': 'Credits' },
@@ -273,7 +272,9 @@ class SpecialTabsTest(pyauto.PyUITest):
expected_title = 'title' in properties and properties['title'] or url
actual_title = self.GetActiveTabTitle()
self.assertTrue(self.WaitUntil(
- lambda: self.GetActiveTabTitle(), expect_retval=expected_title))
+ lambda: self.GetActiveTabTitle(), expect_retval=expected_title),
+ msg='Title did not match for %s. Expected: %s. Got %s' % (
+ url, expect_retval, self.GetActiveTabTitle()))
include_list = []
exclude_list = []
no_csp = 'CSP' in properties and not properties['CSP']
@@ -301,7 +302,8 @@ class SpecialTabsTest(pyauto.PyUITest):
self.assertEqual(result, 'executed',
msg='Got %s for %s' % (result, url))
else:
- self.assertEqual(result, 'blocked');
+ self.assertEqual(result, 'blocked',
+ msg='Got %s for %s' % (result, url))
# Restart browser so that every URL gets a fresh instance.
self.RestartBrowser(clear_profile=False)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698