Made parse_html_subset pre-compilable.

Made parse_html_subset pre-compilable.

Moved helper functions and static collections into scoped closure.
These changes:
  - remove pollution of the global namespace
  - avoid the creation of new helper functions each time the parse
    method is called
  - allow this file to be pre-compiled

BUG=121430
TEST=Run unit tests by loading parse_html_subset_test.html


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134746

[Kevin Greer, 2012-05-01 14:54:10]

Please review.

[arv (Not doing code reviews), 2012-05-01 16:56:08]

LGTM

https://chromiumcodereview.appspot.com/10261025/diff/1/chrome/browser/resourc...
File chrome/browser/resources/shared/js/parse_html_subset.js (right):

https://chromiumcodereview.appspot.com/10261025/diff/1/chrome/browser/resourc...
chrome/browser/resources/shared/js/parse_html_subset.js:18: var
allowedAttributes = {
The initial idea was that these were part of the "API". But since no one ended
up modifying this, this should be safe.

https://chromiumcodereview.appspot.com/10261025/diff/1/chrome/browser/resourc...
chrome/browser/resources/shared/js/parse_html_subset.js:97: });
This indentation is wrong.

[Kevin Greer, 2012-05-01 17:12:35]

Indentation fixed.

https://chromiumcodereview.appspot.com/10261025/diff/1/chrome/browser/resourc...
File chrome/browser/resources/shared/js/parse_html_subset.js (right):

https://chromiumcodereview.appspot.com/10261025/diff/1/chrome/browser/resourc...
chrome/browser/resources/shared/js/parse_html_subset.js:97: });
Fixed.
On 2012/05/01 16:56:08, arv wrote:
> This indentation is wrong.

[flackr, 2012-05-01 17:13:00]

lgtm

[commit-bot: I haz the power, 2012-05-01 17:13:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kgr@chromium.org/10261025/4001

[commit-bot: I haz the power, 2012-05-01 19:12:21]

Change committed as 134746