Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 10261022: Roll WebGL conformance tests to r134617. (Closed)

Created:
8 years, 7 months ago by apatrick_chromium
Modified:
8 years, 7 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Roll WebGL conformance tests to r134617. BUG=125679 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134718

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/gpu/webgl_conformance_test_expectations.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/gpu/webgl_conformance_test_list_autogen.h View 14 chunks +50 lines, -2 lines 3 comments Download

Messages

Total messages: 6 (0 generated)
apatrick_chromium
Failures added based on gpu bot try results after WebGL conformance test roll.
8 years, 7 months ago (2012-05-01 01:14:34 UTC) #1
Ken Russell (switch to Gerrit)
A comment on the addition of one of the tests. https://chromiumcodereview.appspot.com/10261022/diff/3001/chrome/test/gpu/webgl_conformance_test_list_autogen.h File chrome/test/gpu/webgl_conformance_test_list_autogen.h (right): https://chromiumcodereview.appspot.com/10261022/diff/3001/chrome/test/gpu/webgl_conformance_test_list_autogen.h#newcode171 ...
8 years, 7 months ago (2012-05-01 01:43:59 UTC) #2
Zhenyao Mo
https://chromiumcodereview.appspot.com/10261022/diff/3001/chrome/test/gpu/webgl_conformance_test_list_autogen.h File chrome/test/gpu/webgl_conformance_test_list_autogen.h (right): https://chromiumcodereview.appspot.com/10261022/diff/3001/chrome/test/gpu/webgl_conformance_test_list_autogen.h#newcode171 chrome/test/gpu/webgl_conformance_test_list_autogen.h:171: "conformance/context/context-creation-and-destruction.html"); On 2012/05/01 01:43:59, kbr wrote: > This one ...
8 years, 7 months ago (2012-05-01 17:25:29 UTC) #3
Ken Russell (switch to Gerrit)
https://chromiumcodereview.appspot.com/10261022/diff/3001/chrome/test/gpu/webgl_conformance_test_list_autogen.h File chrome/test/gpu/webgl_conformance_test_list_autogen.h (right): https://chromiumcodereview.appspot.com/10261022/diff/3001/chrome/test/gpu/webgl_conformance_test_list_autogen.h#newcode171 chrome/test/gpu/webgl_conformance_test_list_autogen.h:171: "conformance/context/context-creation-and-destruction.html"); On 2012/05/01 17:25:29, Zhenyao Mo wrote: > On ...
8 years, 7 months ago (2012-05-01 17:48:03 UTC) #4
Zhenyao Mo
On 2012/05/01 17:48:03, kbr wrote: > https://chromiumcodereview.appspot.com/10261022/diff/3001/chrome/test/gpu/webgl_conformance_test_list_autogen.h > File chrome/test/gpu/webgl_conformance_test_list_autogen.h (right): > > https://chromiumcodereview.appspot.com/10261022/diff/3001/chrome/test/gpu/webgl_conformance_test_list_autogen.h#newcode171 > ...
8 years, 7 months ago (2012-05-01 17:51:04 UTC) #5
Ken Russell (switch to Gerrit)
8 years, 7 months ago (2012-05-01 17:53:12 UTC) #6
On 2012/05/01 17:51:04, Zhenyao Mo wrote:
> On 2012/05/01 17:48:03, kbr wrote:
> >
>
https://chromiumcodereview.appspot.com/10261022/diff/3001/chrome/test/gpu/web...
> > File chrome/test/gpu/webgl_conformance_test_list_autogen.h (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10261022/diff/3001/chrome/test/gpu/web...
> > chrome/test/gpu/webgl_conformance_test_list_autogen.h:171:
> > "conformance/context/context-creation-and-destruction.html");
> > On 2012/05/01 17:25:29, Zhenyao Mo wrote:
> > > On 2012/05/01 01:43:59, kbr wrote:
> > > > This one might be problematic to add right now. It is known to cause
> > > flakiness;
> > > > see http://crbug.com/124238 . I think we should mark it as a known
failure
> > for
> > > > the moment (which I believe will cause it to be removed from this test
> > list).
> > > 
> > > It is already marked as FAIL in this CL in the test_expectations.txt
> > 
> > I thought that if the test was marked FAIL then it wasn't added to the test
> > list. Or is it just skipped during the running of the test?
> 
> If a test is marked as anything other than PASS, then we simply return early
> without truly running the test.

OK, I see. LGTM; sorry for the delay.

Powered by Google App Engine
This is Rietveld 408576698