Issue 10260034: ash: Do not add the tray bubble twice in the message-loop's observer list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10260034: ash: Do not add the tray bubble twice in the message-loop's observer list. (Closed)

Created:
8 years, 7 months ago by sadrul

Modified:
8 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Do not add the tray bubble twice in the message-loop's observer list. This fixes a crash when the bubble tries to add itself as an observer again when it is being displayed. BUG=125778 TEST=click on the status tray, no crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134748

Patch Set 1 #

Patch Set 2 : . #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	ash/system/tray/system_tray.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages