Issue 10260014: Ensure reload of elements pointer in StoreFastDoubleElement stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10260014: Ensure reload of elements pointer in StoreFastDoubleElement stub. (Closed)

Created:
8 years, 7 months ago by danno

Modified:
8 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Ensure reload of elements pointer in StoreFastDoubleElement stub. R=mstarzinger@chromium.org TEST=test/mjsunit/regress/regress-125515.js BUG=chromium:125515 Committed: https://code.google.com/p/v8/source/detail?r=11479

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -1 line)			Patch
M	src/objects-inl.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-125515.js	View	1 chunk	+41 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 7 months ago (2012-04-30 16:42:09 UTC) #2

LGTM (with two nits).

https://chromiumcodereview.appspot.com/10260014/diff/1/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-125515.js (right):

https://chromiumcodereview.appspot.com/10260014/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-125515.js:28: // Flags: --allow-natives-syntax
--expose-gc --debug-code
It seems as if --allow-natives-syntax is obsolete here.

https://chromiumcodereview.appspot.com/10260014/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-125515.js:37: // Make sure that a ends up old space
Missing "in".

Expand Messages | Collapse Messages