Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 10260010: Modifies the external extension preferences loader to load not only external_extensions.json but al… (Closed)

Created:
8 years, 7 months ago by Finnur
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

This is based on a patch from Alexandre Abreu (http://codereview.chromium.org/9963120/) that I've modified slightly to work on Windows. Modifies the external extension preferences loader to load not only external_extensions.json but also extensions based on standalone per-extension json files. The new json files should be named <extension-id>.json and formatted as such: { "external_crx": "<relative path from the .json file>", "external_version": "x.x" } Also, for Linux, added a new search path: /usr/share/[chromium|google-chrome]/extensions. And finally, modifies the documentation to account for that change and to deprecate the external_extension.json files uses. BUG=75174 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134892

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -101 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/external_extension_provider_impl.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/extensions/external_pref_extension_loader.h View 2 chunks +27 lines, -6 lines 0 comments Download
M chrome/browser/extensions/external_pref_extension_loader.cc View 1 7 chunks +144 lines, -40 lines 0 comments Download
M chrome/common/chrome_paths.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/chrome_paths.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/external_extensions.html View 9 chunks +32 lines, -27 lines 0 comments Download
M chrome/common/extensions/docs/static/external_extensions.html View 9 chunks +33 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Finnur
Sam, can you take a look at the changes I did for external_pref_extension_loader.cc (that's the ...
8 years, 7 months ago (2012-04-30 13:31:33 UTC) #1
Alexandre Abreu
On 2012/04/30 13:31:33, Finnur wrote: > Sam, can you take a look at the changes ...
8 years, 7 months ago (2012-04-30 14:14:32 UTC) #2
skerner
LGTM There are uses of the external extensions json format other than the prefs, so ...
8 years, 7 months ago (2012-04-30 18:26:48 UTC) #3
Finnur
I'm not in any hurry to remove external_extensions.json. Just wanted the new scheme to be ...
8 years, 7 months ago (2012-04-30 21:25:51 UTC) #4
Alexandre Abreu
On 2012/04/30 21:25:51, Finnur wrote: > I'm not in any hurry to remove external_extensions.json. Just ...
8 years, 7 months ago (2012-05-15 15:31:54 UTC) #5
Finnur
8 years, 7 months ago (2012-05-15 17:11:22 UTC) #6
On 2012/05/15 15:31:54, Alexandre Abreu wrote:
> On 2012/04/30 21:25:51, Finnur wrote:
> > I'm not in any hurry to remove external_extensions.json. Just wanted the new
> > scheme to be the de-facto cross-platform prefs standard. 
> > 
> > But, out of curiosity... Who uses external_extensions.json and for what
> purpose
> > other than the prefs system??
> 
> Any news about that?

Seems like a couple of internal projects within Chrome may have used it at some
point. Not clear whether they still do. I wouldn't worry too much about this,
since it will only affect them when we remove support. That's long term though,
no need to worry about it in the interim.

Powered by Google App Engine
This is Rietveld 408576698