Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 10260001: Remove panel size limit when user resizes it. (Closed)

Created:
8 years, 8 months ago by Dmitry Titov
Modified:
8 years, 7 months ago
Reviewers:
jennb
CC:
chromium-reviews, jennb, jianli, dcheng, Andrei
Visibility:
Public.

Description

Remove panel size limit when user resizes it. BUG=123669 TEST=existing panel resize tests, modified Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134559

Patch Set 1 #

Patch Set 2 : fix build break in tests #

Patch Set 3 : fix tests #

Total comments: 6

Patch Set 4 : cr feedback #

Total comments: 1

Patch Set 5 : tweaked min width #

Patch Set 6 : fixed typo #

Patch Set 7 : attempting to fix too flexible win test #

Total comments: 2

Patch Set 8 : patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -27 lines) Patch
M chrome/browser/ui/panels/detached_panel_strip.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/docked_panel_strip.cc View 1 2 3 4 5 6 7 5 chunks +20 lines, -13 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view_browsertest.cc View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_resize_browsertest.cc View 1 2 3 1 chunk +9 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_resize_controller.cc View 1 chunk +16 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dmitry Titov
Also, modified Panel::ClampSize to take const parameter and return Size, to blend more with the ...
8 years, 8 months ago (2012-04-27 23:10:02 UTC) #1
jennb
https://chromiumcodereview.appspot.com/10260001/diff/4008/chrome/browser/ui/panels/docked_panel_strip.cc File chrome/browser/ui/panels/docked_panel_strip.cc (left): https://chromiumcodereview.appspot.com/10260001/diff/4008/chrome/browser/ui/panels/docked_panel_strip.cc#oldcode871 chrome/browser/ui/panels/docked_panel_strip.cc:871: // Always update limits, even on existing panels, in ...
8 years, 8 months ago (2012-04-28 00:09:48 UTC) #2
Dmitry Titov
https://chromiumcodereview.appspot.com/10260001/diff/4008/chrome/browser/ui/panels/docked_panel_strip.cc File chrome/browser/ui/panels/docked_panel_strip.cc (left): https://chromiumcodereview.appspot.com/10260001/diff/4008/chrome/browser/ui/panels/docked_panel_strip.cc#oldcode871 chrome/browser/ui/panels/docked_panel_strip.cc:871: // Always update limits, even on existing panels, in ...
8 years, 8 months ago (2012-04-28 00:57:40 UTC) #3
jennb
Looks like a real test failure. Maybe it doesn't like the larger min width. :-( ...
8 years, 8 months ago (2012-04-28 03:38:02 UTC) #4
Dmitry Titov
On 2012/04/28 03:38:02, jennb wrote: > Looks like a real test failure. Maybe it doesn't ...
8 years, 7 months ago (2012-04-29 19:31:20 UTC) #5
Dmitry Titov
Another test fails. In a view browsertest on win, we create a panel to test ...
8 years, 7 months ago (2012-04-29 21:19:56 UTC) #6
jennb
8 years, 7 months ago (2012-04-30 17:03:31 UTC) #7
LGTM

http://codereview.chromium.org/10260001/diff/22002/chrome/browser/ui/panels/d...
File chrome/browser/ui/panels/docked_panel_strip.cc (right):

http://codereview.chromium.org/10260001/diff/22002/chrome/browser/ui/panels/d...
chrome/browser/ui/panels/docked_panel_strip.cc:58: // Motivation for height is
to allow autosized tightly-wrapped panel with a
The height comment is wrong as a height of 20 is less than the height of the
titlebar alone.

http://codereview.chromium.org/10260001/diff/22002/chrome/browser/ui/panels/d...
chrome/browser/ui/panels/docked_panel_strip.cc:876: // changed. If the panel is
not autoresizable, then it's either was resized
nit: it's either was -> it was

Powered by Google App Engine
This is Rietveld 408576698