[File Manager] Better Google Drive promo layout in Open/Save dialogs

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * FileManager constructor.
  *
  * FileManager objects encapsulate the functionality of the file selector
  * dialogs, as well as the full screen file manager application (though the
  * latter is not yet implemented).
@@ skipping 734 matching lines @@
 
     var retry = this.document_.createElement('button');
     retry.className = 'gdata retry';
     retry.textContent = str('GDATA_RETRY');
     retry.onclick = this.initGData_.bind(this, false /* retry */);
     this.unmountedPanel_.appendChild(retry);
 
     var learnMore = this.document_.createElement('div');
     learnMore.className = 'gdata learn-more plain-link';
     learnMore.textContent = str('GDATA_LEARN_MORE');
-    learnMore.addEventListener('click', function() {
-       chrome.tabs.create({url: GOOGLE_DRIVE_ERROR_HELP_URL});
-    });
+    learnMore.addEventListener('click',
+        this.onExternalLinkClick_.bind(this, GOOGLE_DRIVE_ERROR_HELP_URL));
     this.unmountedPanel_.appendChild(learnMore);
   };
 
   FileManager.prototype.onDataModelSplice_ = function(event) {
     var checkbox = this.document_.querySelector('#select-all-checkbox');
     if (checkbox)
       this.updateSelectAllCheckboxState_(checkbox);
   };
 
   FileManager.prototype.onDataModelPermuted_ = function(event) {
@@ skipping 1645 matching lines @@
     label.appendChild(this.document_.createTextNode(task.title));
     item.appendChild(label);
 
     return item;
   };
 
   FileManager.prototype.getExtensionId_ = function() {
     return chrome.extension.getURL('').split('/')[2];
   };
 
-  FileManager.prototype.onDownloadsWarningClick_ = function(event) {
-    chrome.tabs.create({url: DOWNLOADS_FAQ_URL});
+  FileManager.prototype.onExternalLinkClick_ = function(url) {
+    chrome.tabs.create({url: url});
     if (this.dialogType_ != FileManager.DialogType.FULL_PAGE) {
       this.onCancel_();
     }
   };
 
   FileManager.prototype.onTaskItemClicked_ = function(event) {
     this.dispatchFileTask_(event.item.task.taskId, this.selection.urls);
   };
 
   /**
@@ skipping 862 matching lines @@
   /**
    * Show or hide the "Low disk space" warning.
    * @param {boolean} show True if the box need to be shown.
    */
   FileManager.prototype.showLowDiskSpaceWarning_ = function(show) {
     var box = this.dialogDom_.querySelector('.downloads-warning');
     if (show) {
       var html = util.htmlUnescape(str('DOWNLOADS_DIRECTORY_WARNING'));
       box.lastElementChild.innerHTML = html;
       var link = box.querySelector('a');
-      link.addEventListener('click', this.onDownloadsWarningClick_.bind(this));
+      link.addEventListener('click',
+          this.onExternalLinkClick_.bind(this, DOWNLOADS_FAQ_URL));
     } else {
       box.lastElementChild.innerHTML = '';
     }
 
     box.hidden = !show;
     this.requestResize_(100);
   };
 
   /**
    * Update the location in the address bar.
@@ skipping 84 matching lines @@
         function(result) {
           if (!result) {
             console.log('Failed to add file watch');
             this.watchedDirectoryUrl_ = null;
           }
         }.bind(this));
     }
 
     if (event.newDirEntry.unmounted)
       this.dialogContainer_.setAttribute('unmounted', true);
-    else
+    else {
       this.dialogContainer_.removeAttribute('unmounted');
+      // Need to resize explicitly because the list container had display:none.
+      this.onResize_();
+    }
 
     if (this.isOnGData()) {
       this.dialogContainer_.setAttribute('gdata', true);
       if (event.newDirEntry.unmounted) {
         this.initGData_(true /* directory changed */);
       }
     } else {
       this.dialogContainer_.removeAttribute('gdata');
     }
   };
@@ skipping 887 matching lines @@
       title.textContent =
           strf('GDATA_WELCOME_TITLE', str('GDATA_PRODUCT_NAME'));
 
       var text = createDiv('gdrive-welcome-text', message);
       text.innerHTML = strf(messageId, str('GDATA_PRODUCT_NAME'));
 
       var links = createDiv('gdrive-welcome-links', message);
 
       var more = createDiv('gdrive-welcome-more plain-link', links);
       more.textContent = str('GDATA_LEARN_MORE');
-      more.addEventListener('click', function() {
-        chrome.tabs.create({url: GOOGLE_DRIVE_FAQ_URL});
-      });
+      more.addEventListener('click',
+          self.onExternalLinkClick_.bind(self, GOOGLE_DRIVE_FAQ_URL));
 
       var dismiss = createDiv('gdrive-welcome-dismiss plain-link', links);
       dismiss.textContent = str('GDATA_WELCOME_DISMISS');
       dismiss.addEventListener('click', closeBanner);
     }
 
     function maybeShowBanner() {
       if (!self.isOnGData()) {
         self.dialogContainer_.removeAttribute('gdrive-welcome');
         return;
@@ skipping 23 matching lines @@
     }
 
     this.directoryModel_.addEventListener('scan-completed', maybeShowBanner);
 
     var style = this.document_.createElement('link');
     style.rel = 'stylesheet';
     style.href = 'css/gdrive_welcome.css';
     this.document_.head.appendChild(style);
   };
 })();