Issue 10258011: [File Manager] Better Google Drive promo layout in Open/Save dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10258011: [File Manager] Better Google Drive promo layout in Open/Save dialogs (Closed)

Created:
8 years, 7 months ago by Vladislav Kaznacheev

Modified:
8 years, 7 months ago

Reviewers:
Dmitry Zvorygin

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[File Manager] Better Google Drive promo layout in Open/Save dialogs BUG=chromium-os:30138, chromium-os:30139 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134473

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -25 lines)			Patch
M	chrome/browser/resources/file_manager/css/gdrive_welcome.css	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/harness.html	View	3 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	5 chunks	+12 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View	1 chunk	+10 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

Dmitry Zvorygin

8 years, 7 months ago (2012-04-28 13:20:45 UTC) #2

On 2012/04/28 12:42:27, Vladislav Kaznacheev wrote:
> Please review. This fixed two bugs.

LGTM.