Issue 10257028: Revert 134443 - Broke win_aura

Issue 10257028: Revert 134443 - Broke win_aura (Closed)

Created:
8 years, 8 months ago by Ryan Sleevi

Modified:
8 years, 8 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 134443 - Broke win_aura Generate crash dumps when a hung PPAPI plugin is force terminated. TEST=none BUG=123021 Review URL: http://codereview.chromium.org/10253016 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134455

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -77 lines)			Patch
D	chrome/browser/hang_monitor/hang_crash_dump_win.h	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	chrome/browser/hang_monitor/hang_crash_dump_win.cc	View	1 chunk	+0 lines, -45 lines	0 comments	Download
M	chrome/browser/hang_monitor/hung_window_detector.cc	View	2 chunks	+37 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/hung_plugin_tab_helper.cc	View	3 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

http://build.chromium.org/p/chromium/builders/Win%20Aura/builds/11338/steps/compile/logs/stdio 4> Creating library ..\build\Debug\lib\chrome_dll.lib and object ..\build\Debug\lib\chrome_dll.exp 4>browser.lib(hung_plugin_tab_helper.obj) :error LNK2019: unresolved external symbol "void ...

8 years, 8 months ago (2012-04-28 08:08:18 UTC) #2

brettw

8 years, 7 months ago (2012-04-30 05:32:25 UTC) #3

Ah, looks like Aura excludes that entire directory :(

On Sat, Apr 28, 2012 at 1:08 AM,  <rsleevi@chromium.org> wrote:
>
http://build.chromium.org/p/chromium/builders/Win%20Aura/builds/11338/steps/c...
>
> 4>   Creating library ..\build\Debug\lib\chrome_dll.lib and object
> ..\build\Debug\lib\chrome_dll.exp
> 4>browser.lib(hung_plugin_tab_helper.obj) :error LNK2019: unresolved
> external
> symbol "void __cdecl CrashDumpAndTerminateHungChildProcess(void *)"
> (?CrashDumpAndTerminateHungChildProcess@@YAXPAX@Z) referenced in function
> "void
> __cdecl `anonymous namespace'::KillPluginOnIOThread(int)"
> (?KillPluginOnIOThread@?A0x40317067@@YAXH@Z)
> 4>..\build\Debug\chrome.dll : fatalerror LNK1120: 1 unresolved externals
>
>
> 5>   Creating library ..\build\Debug\lib\unit_tests.lib and object
> ..\build\Debug\lib\unit_tests.exp
> 5>browser.lib(hung_plugin_tab_helper.obj) :error LNK2019: unresolved
> external
> symbol "void __cdecl CrashDumpAndTerminateHungChildProcess(void *)"
> (?CrashDumpAndTerminateHungChildProcess@@YAXPAX@Z) referenced in function
> "void
> __cdecl `anonymous namespace'::KillPluginOnIOThread(int)"
> (?KillPluginOnIOThread@?A0x40317067@@YAXH@Z)
> 5>..\build\Debug\unit_tests.exe : fatalerror LNK1120: 1 unresolved externals
>
> 7>   Creating library ..\build\Debug\lib\ui_tests.lib and object
> ..\build\Debug\lib\ui_tests.exp
> 7>browser.lib(hung_plugin_tab_helper.obj) :error LNK2019: unresolved
> external
> symbol "void __cdecl CrashDumpAndTerminateHungChildProcess(void *)"
> (?CrashDumpAndTerminateHungChildProcess@@YAXPAX@Z) referenced in function
> "void
> __cdecl `anonymous namespace'::KillPluginOnIOThread(int)"
> (?KillPluginOnIOThread@?A0x40317067@@YAXH@Z)
> 7>..\build\Debug\ui_tests.exe : fatalerror LNK1120: 1 unresolved externals
>
>
> Tried a clobber, in the event it wasn't picking up the .gypi, but same
> failures
> post-clobber.
>
> http://codereview.chromium.org/10257028/

Expand Messages | Collapse Messages