Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1025663002: Implement oauth token external handler checking. (Closed)

Created:
5 years, 9 months ago by Denis Kuznetsov (DE-MUC)
Modified:
5 years, 9 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement oauth token external handler checking. BUG=462445 Committed: https://crrev.com/62ed2586439bca729c415538140367b852487792 Cr-Commit-Position: refs/heads/master@{#322042}

Patch Set 1 #

Patch Set 2 : Add comments #

Total comments: 16

Patch Set 3 : Address review comments #

Patch Set 4 : Merge with ToT #

Patch Set 5 : Update fake user manager #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -31 lines) Patch
A chrome/browser/chromeos/login/signin/token_handler_util.h View 1 2 1 chunk +90 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/signin/token_handler_util.cc View 1 2 1 chunk +116 lines, -0 lines 1 comment Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.h View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 2 3 4 4 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_chrome_user_manager.h View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M components/user_manager.gypi View 2 chunks +1 line, -1 line 0 comments Download
M components/user_manager/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M components/user_manager/user.h View 3 chunks +6 lines, -5 lines 0 comments Download
M components/user_manager/user.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager/user_id.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/user_manager/user_info.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/user_manager/user_manager.h View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M components/user_manager/user_manager_base.h View 1 2 3 chunks +6 lines, -16 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Denis Kuznetsov (DE-MUC)
PTAL
5 years, 9 months ago (2015-03-20 14:02:38 UTC) #2
Nikita (slow)
lgtm with nits https://codereview.chromium.org/1025663002/diff/20001/chrome/browser/chromeos/login/signin/token_handler_util.cc File chrome/browser/chromeos/login/signin/token_handler_util.cc (right): https://codereview.chromium.org/1025663002/diff/20001/chrome/browser/chromeos/login/signin/token_handler_util.cc#newcode1 chrome/browser/chromeos/login/signin/token_handler_util.cc:1: // Copyright 2014 The Chromium Authors. ...
5 years, 9 months ago (2015-03-20 18:06:50 UTC) #3
Denis Kuznetsov (DE-MUC)
https://codereview.chromium.org/1025663002/diff/20001/chrome/browser/chromeos/login/signin/token_handler_util.cc File chrome/browser/chromeos/login/signin/token_handler_util.cc (right): https://codereview.chromium.org/1025663002/diff/20001/chrome/browser/chromeos/login/signin/token_handler_util.cc#newcode1 chrome/browser/chromeos/login/signin/token_handler_util.cc:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 9 months ago (2015-03-20 19:50:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025663002/40001
5 years, 9 months ago (2015-03-20 19:51:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/35367) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-20 19:55:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025663002/60001
5 years, 9 months ago (2015-03-23 16:57:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/38749)
5 years, 9 months ago (2015-03-23 18:12:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025663002/80001
5 years, 9 months ago (2015-03-24 17:19:32 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-24 19:08:46 UTC) #18
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/62ed2586439bca729c415538140367b852487792 Cr-Commit-Position: refs/heads/master@{#322042}
5 years, 9 months ago (2015-03-24 19:09:16 UTC) #19
Nikita (slow)
5 years, 9 months ago (2015-03-25 17:08:28 UTC) #20
Message was sent while issue was closed. 
https://codereview.chromium.org/1025663002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/signin/token_handler_util.cc (right):

https://codereview.chromium.org/1025663002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/login/signin/token_handler_util.cc:42: if
(!user_manager_->FindKnownUserPrefs(user_id, &dict))
Lines 42-47 should be moved to UserManagerBase i.e. provide API to remove a
single pref.

Powered by Google App Engine
This is Rietveld 408576698