Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Issue 10256004: [File Manager] Fixed an error message when pinning a GDrive file failed (Closed)

Created:
8 years, 8 months ago by Vladislav Kaznacheev
Modified:
8 years, 7 months ago
Reviewers:
Dmitry Zvorygin
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[File Manager] Fixed an error message when pinning a GDrive file failed BUG=chromium-os:27931 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134471

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 2 chunks +3 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Vladislav Kaznacheev
Please review another small patch
8 years, 8 months ago (2012-04-27 15:24:42 UTC) #1
Vladislav Kaznacheev
Please review
8 years, 7 months ago (2012-04-28 10:47:49 UTC) #2
Dmitry Zvorygin
On 2012/04/28 10:47:49, Vladislav Kaznacheev wrote: > Please review LGTM.
8 years, 7 months ago (2012-04-28 10:58:18 UTC) #3
Dmitry Zvorygin
https://chromiumcodereview.appspot.com/10256004/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/10256004/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode3114 chrome/browser/resources/file_manager/js/file_manager.js:3114: self.metadataCache_.get(entry, 'filesystem', function(filesystem) { Maybe not this changeset issue, ...
8 years, 7 months ago (2012-04-28 10:58:24 UTC) #4
Vladislav Kaznacheev
8 years, 7 months ago (2012-04-28 11:12:40 UTC) #5
https://chromiumcodereview.appspot.com/10256004/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10256004/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:3114:
self.metadataCache_.get(entry, 'filesystem', function(filesystem) {
As far as I know it is. We can always revisit it later if needed.
On 2012/04/28 10:58:24, Dmitry Zvorygin wrote:
> Maybe not this changeset issue, but if the only error we can receive is
> 'out_of_space'?

Powered by Google App Engine
This is Rietveld 408576698