Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10255022: Revert 134389 - Fix an incorrectly written policy test. It was using a hook incorrectly and checkin… (Closed)

Created:
8 years, 8 months ago by Nirnimesh
Modified:
8 years, 8 months ago
Reviewers:
craigdh
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Revert 134389 - Fix an incorrectly written policy test. It was using a hook incorrectly and checking for the wrong condition. +++++++++++++++++++++++ REVERT NOTES Broke test http://build.chromium.org/p/chromium.pyauto/builders/Win7/builds/21229/steps/pyauto_functional_tests/logs/stdio ====================================================================== ERROR: policy.PolicyTest.testDefaultSearchProviderOptions: "Verify a default search is performed when using omnibox." ---------------------------------------------------------------------- Traceback (most recent call last): File "E:\b\build\slave\Win7\build\src\chrome\test\functional\policy.py", line 533, in testDefaultSearchProviderOptions self.OmniboxAcceptInput() File "src\chrome\test\functional\..\pyautolib\pyauto.py", line 1184, in OmniboxAcceptInput self._GetResultFromJSONRequest(cmd_dict, windex=windex) File "src\chrome\test\functional\..\pyautolib\pyauto.py", line 1052, in _GetResultFromJSONRequest additional_info)) JSONInterfaceError: Automation call {'command': 'OmniboxAcceptInput'} received empty response. Additional information: No information available. +++++++++++++++++++++++++ BUG= TEST=functional/policy.py Review URL: http://codereview.chromium.org/10256005 TBR=craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/functional/policy.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nirnimesh
8 years, 8 months ago (2012-04-28 06:29:35 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698