Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 10255005: [File Manager] Open hosted documents in offline mode (Closed)

Created:
8 years, 8 months ago by Vladislav Kaznacheev
Modified:
8 years, 7 months ago
Reviewers:
Dmitry Zvorygin
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[File Manager] Open hosted documents in offline mode BUG=chromium-os:28449 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134466

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/browser/resources/file_manager/js/metadata/metadata_cache.js View 1 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Vladislav Kaznacheev
Please review
8 years, 8 months ago (2012-04-27 15:12:28 UTC) #1
Vladislav Kaznacheev
Please review
8 years, 7 months ago (2012-04-28 10:47:58 UTC) #2
Dmitry Zvorygin
LGTM after that. https://chromiumcodereview.appspot.com/10255005/diff/1/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js File chrome/browser/resources/file_manager/js/metadata/metadata_cache.js (right): https://chromiumcodereview.appspot.com/10255005/diff/1/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js#newcode627 chrome/browser/resources/file_manager/js/metadata/metadata_cache.js:627: (data.isHosted && GDataProvider.OFFLINE_DOCS_REGEXP.exec(data.editUrl)); I'm not a ...
8 years, 7 months ago (2012-04-28 10:55:42 UTC) #3
Vladislav Kaznacheev
8 years, 7 months ago (2012-04-28 11:05:21 UTC) #4
https://chromiumcodereview.appspot.com/10255005/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/metadata/metadata_cache.js
(right):

https://chromiumcodereview.appspot.com/10255005/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/metadata/metadata_cache.js:627:
(data.isHosted && GDataProvider.OFFLINE_DOCS_REGEXP.exec(data.editUrl));
You are right, |test| is more appropriate.

On 2012/04/28 10:55:42, Dmitry Zvorygin wrote:
> I'm not a RegEx guru, but why not 'test' here, instead of 'exec'?

Powered by Google App Engine
This is Rietveld 408576698