Issue 10255005: [File Manager] Open hosted documents in offline mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10255005: [File Manager] Open hosted documents in offline mode (Closed)

Created:
8 years, 8 months ago by Vladislav Kaznacheev

Modified:
8 years, 7 months ago

Reviewers:
Dmitry Zvorygin

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[File Manager] Open hosted documents in offline mode BUG=chromium-os:28449 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134466

Patch Set 2 : Addressed comments #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	chrome/browser/resources/file_manager/js/metadata/metadata_cache.js	View	1	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Zvorygin

LGTM after that. https://chromiumcodereview.appspot.com/10255005/diff/1/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js File chrome/browser/resources/file_manager/js/metadata/metadata_cache.js (right): https://chromiumcodereview.appspot.com/10255005/diff/1/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js#newcode627 chrome/browser/resources/file_manager/js/metadata/metadata_cache.js:627: (data.isHosted && GDataProvider.OFFLINE_DOCS_REGEXP.exec(data.editUrl)); I'm not a ...

8 years, 7 months ago (2012-04-28 10:55:42 UTC) #3

Vladislav Kaznacheev

8 years, 7 months ago (2012-04-28 11:05:21 UTC) #4

https://chromiumcodereview.appspot.com/10255005/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/metadata/metadata_cache.js
(right):

https://chromiumcodereview.appspot.com/10255005/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/metadata/metadata_cache.js:627:
(data.isHosted && GDataProvider.OFFLINE_DOCS_REGEXP.exec(data.editUrl));
You are right, |test| is more appropriate.

On 2012/04/28 10:55:42, Dmitry Zvorygin wrote:
> I'm not a RegEx guru, but why not 'test' here, instead of 'exec'?

Expand Messages | Collapse Messages

Issue 10255005: [File Manager] Open hosted documents in offline mode (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments #

Messages