Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 10254016: Remove url constants for Hung renderer dialog. (Closed)

Created:
8 years, 8 months ago by tfarina
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove url constants for Hung renderer dialog. The WebUI dialog was added at r97745, and removed at r122290. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/common/url_constants.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 8 months ago (2012-04-27 19:53:06 UTC) #1
Ben Goodger (Google)
8 years, 8 months ago (2012-04-27 20:42:28 UTC) #2
LGTM

On Fri, Apr 27, 2012 at 12:53 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Remove url constants for Hung renderer dialog.
>
> The WebUI dialog was added at r97745, and removed at r122290.
>
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10254016/<http://codereview.chromium.org/102...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/common/url_constants.h
>  M chrome/common/url_constants.cc
>
>
> Index: chrome/common/url_constants.cc
> diff --git a/chrome/common/url_constants.**cc
> b/chrome/common/url_constants.**cc
> index 8f7db11adf100bf31abb35bc0d34b0**585b696d18..**
> d8a976231abed090a21823392c229c**6e21c8953a 100644
> --- a/chrome/common/url_constants.**cc
> +++ b/chrome/common/url_constants.**cc
> @@ -42,7 +42,6 @@ const char kChromeUIFlashURL[] = "chrome://flash/";
>  const char kChromeUIHelpFrameURL[] = "chrome://help-frame/";
>  const char kChromeUIHistoryURL[] = "chrome://history/";
>  const char kChromeUIHistoryFrameURL[] = "chrome://history-frame/";
> -const char kChromeUIHungRendererDialogURL**[] =
> "chrome://hung-renderer/";
>  const char kChromeUIInputWindowDialogURL[**] =
> "chrome://input-window-dialog/**";
>  const char kChromeUIInspectURL[] = "chrome://inspect/";
>  const char kChromeUIIPCURL[] = "chrome://ipc/";
> @@ -144,7 +143,6 @@ const char kChromeUIHelpHost[] = "help";
>  const char kChromeUIHistogramsHost[] = "histograms";
>  const char kChromeUIHistoryHost[] = "history";
>  const char kChromeUIHistoryFrameHost[] = "history-frame";
> -const char kChromeUIHungRendererDialogHos**t[] = "hung-renderer";
>  const char kChromeUIInputWindowDialogHost**[] = "input-window-dialog";
>  const char kChromeUIInspectHost[] = "inspect";
>  const char kChromeUIIPCHost[] = "ipc";
> Index: chrome/common/url_constants.h
> diff --git a/chrome/common/url_constants.**h
> b/chrome/common/url_constants.**h
> index 880b2f89debe777a5f3d0263032401**335f777ebe..**
> c25f15c11fd2405e623657d93e7604**e8c4f1c825 100644
> --- a/chrome/common/url_constants.**h
> +++ b/chrome/common/url_constants.**h
> @@ -42,7 +42,6 @@ extern const char kChromeUIFlashURL[];
>  extern const char kChromeUIHelpFrameURL[];
>  extern const char kChromeUIHistoryURL[];
>  extern const char kChromeUIHistoryFrameURL[];
> -extern const char kChromeUIHungRendererDialogURL**[];
>  extern const char kChromeUIInputWindowDialogURL[**];
>  extern const char kChromeUIInspectURL[];
>  extern const char kChromeUIIPCURL[];
> @@ -141,7 +140,6 @@ extern const char kChromeUIHangHost[];
>  extern const char kChromeUIHistogramsHost[];
>  extern const char kChromeUIHistoryHost[];
>  extern const char kChromeUIHistoryFrameHost[];
> -extern const char kChromeUIHungRendererDialogHos**t[];
>  extern const char kChromeUIInputWindowDialogHost**[];
>  extern const char kChromeUIInspectHost[];
>  extern const char kChromeUIIPCHost[];
>
>
>

Powered by Google App Engine
This is Rietveld 408576698