Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 10254006: Fix LFastLiteral to check boilerplate elements kind. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger
Modified:
8 years, 7 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Fix LFastLiteral to check boilerplate elements kind. Adds a missing check that the elements kind of the boilerplate object still has the expected elements kind, unoptimized code can transition the boilerplate. Corner cases might cause the optimized code to be reentered again. R=danno@chromium.org TEST=mjsunit/regress/regress-fast-literal-transition Committed: https://code.google.com/p/v8/source/detail?r=11470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-fast-literal-transition.js View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 8 months ago (2012-04-27 14:12:53 UTC) #1
danno
8 years, 7 months ago (2012-04-30 12:30:50 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698