Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: tools/testing/perf_testing/run_perf_tests.py

Issue 10252017: Improve posting format for size tests. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/webdriver_test_setup.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/perf_testing/run_perf_tests.py
===================================================================
--- tools/testing/perf_testing/run_perf_tests.py (revision 7103)
+++ tools/testing/perf_testing/run_perf_tests.py (working copy)
@@ -472,7 +472,8 @@
class CommonBrowserFileProcessor(Processor):
def process_file(self, afile):
"""Comb through the html to find the performance results.
- Returns: True if we successfullly posted our data to storage."""
+ Returns: True if we successfully posted our data to storage and/or we can
+ delete the trace file."""
os.chdir(os.path.join(DART_INSTALL_LOCATION, 'tools',
'testing', 'perf_testing'))
if self.test.test_runner.no_upload:
@@ -493,7 +494,7 @@
if i >= len(lines) or revision_num == 0:
# Then this run did not complete. Ignore this tracefile.
- return
+ return True
line = lines[i]
i += 1
@@ -652,7 +653,7 @@
class DromaeoFileProcessor(Processor):
def process_file(self, afile):
"""Comb through the html to find the performance results.
- Returns: True if we successfullly posted our data to storage."""
+ Returns: True if we successfully posted our data to storage."""
if self.test.test_runner.no_upload:
return
parts = afile.split('-')
@@ -774,7 +775,7 @@
Args:
afile: is the filename string we will be processing.
- Returns: True if we successfullly posted our data to storage."""
+ Returns: True if we successfully posted our data to storage."""
os.chdir(os.path.join(DART_INSTALL_LOCATION, 'tools',
'testing', 'perf_testing'))
if self.test.test_runner.no_upload:
@@ -802,7 +803,7 @@
else:
num = float(num)
upload_success = upload_success and self.report_results(
- metric, num, 'browser', variant, revision_num, self.CODE_SIZE)
+ metric, num, 'commandline', variant, revision_num, self.CODE_SIZE)
f.close()
return upload_success
@@ -845,8 +846,8 @@
self.test.test_runner.run_cmd(
[self.test.dart_vm, 'frogc.dart', '--out=swarm-result',
- os.path.join('..', 'samples', 'swarm',
- 'swarm.dart')])
+ os.path.join('..', 'internal', 'golem', 'benchmarks-dart2js', 'tests',
+ 'samples-r6461', 'swarm', 'swarm.dart')])
swarm_size = 0
try:
@@ -856,8 +857,8 @@
self.test.test_runner.run_cmd(
[self.test.dart_vm, 'frogc.dart', '--out=total-result',
- os.path.join('..', 'samples', 'total',
- 'client', 'Total.dart')])
+ os.path.join('..', 'internal', 'golem', 'benchmarks-dart2js', 'tests',
+ 'samples-r6461', 'total', 'client', 'Total.dart')])
total_size = 0
try:
total_size = os.path.getsize('total-result')
@@ -882,7 +883,7 @@
Args:
afile: is the filename string we will be processing.
- Returns: True if we successfullly posted our data to storage."""
+ Returns: True if we successfully posted our data to storage."""
os.chdir(os.path.join(DART_INSTALL_LOCATION, 'tools',
'testing', 'perf_testing'))
if self.test.test_runner.no_upload:
« no previous file with comments | « no previous file | tools/testing/webdriver_test_setup.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698