Issue 10252003: ScopedAllowWait for NativeBackendKWallet::InitWithBus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10252003: ScopedAllowWait for NativeBackendKWallet::InitWithBus (Closed)

Created:
8 years, 8 months ago by battre

Modified:
8 years, 8 months ago

Reviewers:
Mike Mammarella, jam

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ScopedAllowWait for NativeBackendKWallet::InitWithBus Add a ScopedAllowWait to prevend a DCHECK in NativeBackendKWallet::InitWithBus. BUG=125331 TEST=no TBR=mdm@chromium.org,jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134263

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	base/threading/thread_restrictions.h	View	1	3 chunks	+4 lines, -1 line	0 comments	Download
	M	chrome/browser/password_manager/native_backend_kwallet_x.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/10252003/1

8 years, 8 months ago (2012-04-27 10:11:15 UTC) #1

commit-bot: I haz the power

Try job failure for 10252003-1 (retry) (retry) on win_rel for step "browser_tests" (clobber build). It's ...

8 years, 8 months ago (2012-04-27 13:52:44 UTC) #2

Mike Mammarella

8 years, 8 months ago (2012-04-27 18:01:27 UTC) #4

LGTM, though removing this will be pretty tricky. I have some ideas for how to
attack it though.