Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: src/ia32/code-stubs-ia32.cc

Issue 10249003: Small patch to save one jump instruction and one label bind in JSEntryStub. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4996 matching lines...) Expand 10 before | Expand all | Expand 10 after
5007 ExternalReference c_entry_fp(Isolate::kCEntryFPAddress, masm->isolate()); 5007 ExternalReference c_entry_fp(Isolate::kCEntryFPAddress, masm->isolate());
5008 __ push(Operand::StaticVariable(c_entry_fp)); 5008 __ push(Operand::StaticVariable(c_entry_fp));
5009 5009
5010 // If this is the outermost JS call, set js_entry_sp value. 5010 // If this is the outermost JS call, set js_entry_sp value.
5011 ExternalReference js_entry_sp(Isolate::kJSEntrySPAddress, 5011 ExternalReference js_entry_sp(Isolate::kJSEntrySPAddress,
5012 masm->isolate()); 5012 masm->isolate());
5013 __ cmp(Operand::StaticVariable(js_entry_sp), Immediate(0)); 5013 __ cmp(Operand::StaticVariable(js_entry_sp), Immediate(0));
5014 __ j(not_equal, &not_outermost_js, Label::kNear); 5014 __ j(not_equal, &not_outermost_js, Label::kNear);
5015 __ mov(Operand::StaticVariable(js_entry_sp), ebp); 5015 __ mov(Operand::StaticVariable(js_entry_sp), ebp);
5016 __ push(Immediate(Smi::FromInt(StackFrame::OUTERMOST_JSENTRY_FRAME))); 5016 __ push(Immediate(Smi::FromInt(StackFrame::OUTERMOST_JSENTRY_FRAME)));
5017 Label cont; 5017 __ jmp(&invoke, Label::kNear);
5018 __ jmp(&cont, Label::kNear);
5019 __ bind(&not_outermost_js); 5018 __ bind(&not_outermost_js);
5020 __ push(Immediate(Smi::FromInt(StackFrame::INNER_JSENTRY_FRAME))); 5019 __ push(Immediate(Smi::FromInt(StackFrame::INNER_JSENTRY_FRAME)));
5021 __ bind(&cont);
5022 5020
5023 // Jump to a faked try block that does the invoke, with a faked catch 5021 // Jump to a faked try block that does the invoke, with a faked catch
5024 // block that sets the pending exception. 5022 // block that sets the pending exception.
5025 __ jmp(&invoke); 5023 __ jmp(&invoke);
5026 __ bind(&handler_entry); 5024 __ bind(&handler_entry);
5027 handler_offset_ = handler_entry.pos(); 5025 handler_offset_ = handler_entry.pos();
5028 // Caught exception: Store result (exception) in the pending exception 5026 // Caught exception: Store result (exception) in the pending exception
5029 // field in the JSEnv and return a failure sentinel. 5027 // field in the JSEnv and return a failure sentinel.
5030 ExternalReference pending_exception(Isolate::kPendingExceptionAddress, 5028 ExternalReference pending_exception(Isolate::kPendingExceptionAddress,
5031 masm->isolate()); 5029 masm->isolate());
(...skipping 2359 matching lines...) Expand 10 before | Expand all | Expand 10 after
7391 false); 7389 false);
7392 __ pop(edx); 7390 __ pop(edx);
7393 __ ret(0); 7391 __ ret(0);
7394 } 7392 }
7395 7393
7396 #undef __ 7394 #undef __
7397 7395
7398 } } // namespace v8::internal 7396 } } // namespace v8::internal
7399 7397
7400 #endif // V8_TARGET_ARCH_IA32 7398 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698