test rename overhaul: step 8 - language tests

tools/testing/dart/test_runner.dart

Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index e712f7e6659a427d5a513601bfabcfde726da50b..2832652e811765860169fe7ff53aee1934b59b08 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -78,7 +78,10 @@ class TestCase {
            [this.isNegative = false,
             this.info = null]) {
     if (!isNegative) {
-      this.isNegative = displayName.contains("NegativeTest");
+      // TODO(sigmund): dissallow NegativeTest once the test rename overhaul is

[Ivan Posva, 2012/04/27 05:36:39]

Care to explain? Negative tests are occasionally very useful and still should be
supported.

[Bob Nystrom, 2012/04/27 15:55:06]

I think here Siggy just means removing the PascalCase clause
(displayName.contains("NegativeTest")) and only using the "negative_test" one
once all of the files are renamed.

From our conversation yesterday, I'm pretty sure Siggy still expects to support
negative tests.

[Siggi Cherem (dart-lang), 2012/04/30 16:32:55]

That's exactly what I meant - I'll rewrite the TODO to be more clear.

+      // done.
+      this.isNegative = displayName.contains("NegativeTest")
+          || displayName.contains("negative_test");
     }
 
     // Special command handling. If a special command is specified