Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 10248005: Don't make checkdeps ignore includes to directories that are brought in via deps. (Closed)

Created:
8 years, 8 months ago by jam
Modified:
8 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, erikwright (departed), amit, native-client-reviews_googlegroups.com, stevenjb+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, ben+watch_chromium.org, grt+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, jonathan.backer, wez+watch_chromium.org, sanjeevr, simonmorris+watch_chromium.org, feature-media-reviews_chromium.org, pam+watch_chromium.org, piman+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, dhollowa+watch_chromium.org, Ian Vollick, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Don't make checkdeps ignore includes to directories that are brought in via deps. Most of these are already listed in DEPS files, and it seems that we want to prevent includes on them just like normal directories that are in our tree (otherwise content can depend on native_client, for ex) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134296

Patch Set 1 #

Patch Set 2 : reorder #

Patch Set 3 : remove file from other cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -20 lines) Patch
M DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ash/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M base/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/DEPS View 1 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/DEPS View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/nacl/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/DEPS View 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M jingle/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M net/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
M printing/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M remoting/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/checkdeps/checkdeps.py View 4 chunks +3 lines, -16 lines 0 comments Download
M ui/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/compositor/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/DEPS View 1 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/DEPS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
8 years, 8 months ago (2012-04-27 01:01:39 UTC) #1
brettw
lgtm Can you add further exposition to the CL description? In a year somebody will ...
8 years, 8 months ago (2012-04-27 17:41:27 UTC) #2
jam
8 years, 8 months ago (2012-04-27 17:51:37 UTC) #3
On 2012/04/27 17:41:27, brettw wrote:
> lgtm
> 
> Can you add further exposition to the CL description? In a year somebody will
> probably ask me why we don't automatically include the deps things and I won't
> have any idea.

sure

Powered by Google App Engine
This is Rietveld 408576698